fix(signin): Check if session is valid for isFirefoxNonSync before rendering cached signin#20048
Conversation
…ndering cached signin Because: * Now that we offer cached sign-in for non-Sync service browser sign-ins, FxA can show a stale cached sign in page when the user signs out from the browser menu This commit: * Adds a "session is verified" check for Firefox client IDs that have a non-Sync 'service' param before we render cached sign-in closes FXA-13022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
closes FXA-13022
See ticket and comments for more details.
To verify, do this on
mainand then in this branch:about:configand flip thebrowser.smartwindow.enabledprefOn
mainyou'll see the cached sign in page and if you click it you'll see "Session expired". In my branch with the fix, sign in with password is shown.