feat(auth): add passwordless email otp routes#20028
Open
StaberindeZA wants to merge 6 commits intofxa-13016-otp-emailfrom
Open
feat(auth): add passwordless email otp routes#20028StaberindeZA wants to merge 6 commits intofxa-13016-otp-emailfrom
StaberindeZA wants to merge 6 commits intofxa-13016-otp-emailfrom
Conversation
vbudhram
reviewed
Feb 11, 2026
Contributor
vbudhram
left a comment
vbudhram
left a comment
There was a problem hiding this comment.
Just did a first pass mostly nits
| authSalt, | ||
| clientSalt: undefined, | ||
| verifierVersion: this.config.verifierVersion, | ||
| verifyHash: Buffer.alloc(32).toString('hex'), |
Contributor
There was a problem hiding this comment.
Not for this PR, but we do this in alot of places but might make sense to store a random value instead of 0s.
|
|
||
| constructor( | ||
| private log: AuthLogger, | ||
| private db: any, |
Contributor
There was a problem hiding this comment.
We have been moving towarding away from any types. These types should be defined in other routes so can use them.
| }).then(assertions); | ||
| } | ||
|
|
||
| describe('/account/passwordless/send_code', () => { |
Contributor
There was a problem hiding this comment.
We will probably want to add some tests for the account.ts changes as well. Verify the passwordlessSupported is returned.
Because: - Add necessary backend changes to enable passwordless signup and signin with email OTP. This commit: - Adds PasswordlessHandler route handler - Adds passworldess send/resend/confirm routes - Adds tests for PasswordlessHandler Closes #FXA-13014
StaberindeZA
force-pushed
the
fxa-13014-add-passwordless
branch
from
47316ef to
939897a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: # FXA-13014, # FXA-13015
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.