Open
Conversation
Contributor
Author
Contributor
|
Looks good. Merging this is blocked by a view to create a replacement table, correct? |
m-d-bowerman
approved these changes
Aug 13, 2024
Contributor
m-d-bowerman
left a comment
m-d-bowerman
left a comment
There was a problem hiding this comment.
Changes look good. Let's connect with Sydney this week re: requirements for the replacement view for Suggest forecasting and I'll raise that bq-etl PR.
Contributor
Author
@m-d-bowerman Yeah I need to work with Sydney and Sergio to test the view from the notebook, it should be the same except the difference in where it starts so maybe I'm overthinking it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for reviewer:
referenced, the pull request should include the bug number in the title)
.circleci/config.yml) will cause environment variables (particularlycredentials) to be exposed in test logs
telemetry-airflow
responsibly.