test(ads-client): assert shutdown is idempotent - #7558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test covering repeated
shutdown()calls on the ads client.MozAdsClient::shutdowntakes&selfand goes through a lock, so a double shutdown is reachable from the foreign side. Both pieces of state it tears down are alreadyOption::take()—MozAdsTelemetryWrapper::shutdown(ffi/telemetry.rs) andMARSTransport::shutdown_db(mars/transport.rs) — so the behaviour is correct today; this test pins it down.The test builds the client with a real
HttpCache, since that's where a regression would bite:HttpCache::shutdown_db(self)consumes and callsconn.close(), so replacing thetake()with a borrow would make the second close error.Pull Request checklist
cargo test -p ads-clientpasses (96 passed, 1 ignored, 0 failed);cargo fmt --checkandcargo clippy -p ads-client --all-targetsare clean.MARSTransport::shutdown_dbreturnErr(InvalidQuery)on an already-shut-down cache makes it fail; restored and re-verified green.