Removing legacy remote-settings client

CHANGELOG.md

@@ -16,6 +16,10 @@
 ([#14280](https://github.com/mozilla/experimenter/pull/14280))
 * Enable using `PreviousGeckoPrefState` to revert Gecko pref experiments when applicable ([#7157](https://github.com/mozilla/application-services/pull/7157))
 
+### Remote-Settings
+ * Removed old remote-settings client code that is no longer used.
+ * Started renaming `RemoteSettingsConfig2` to `RemoteSettingsConfig`, leaving an alias for the prior struct
+
 ### Error support
 * Removed the `tracing-logging` and `tracing-reporting` features, these are now always enabled.
   We don't believe this should affect any consumers, since they're were already using the

components/nimbus/android/src/test/java/org/mozilla/experiments/nimbus/NimbusBuilderTest.kt

@@ -7,7 +7,7 @@ package org.mozilla.experiments.nimbus
 import android.content.Context
 import androidx.test.core.app.ApplicationProvider
 import kotlinx.coroutines.Job
-import mozilla.appservices.remotesettings.RemoteSettingsConfig2
+import mozilla.appservices.remotesettings.RemoteSettingsConfig
 import mozilla.appservices.remotesettings.RemoteSettingsService
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertFalse
@@ -35,7 +35,7 @@ class NimbusBuilderTest {
         }.build(
             appInfo,
             NimbusServerSettings(
-                rsService = RemoteSettingsService(storageDir = "dummy", config = RemoteSettingsConfig2()),
+                rsService = RemoteSettingsService(storageDir = "dummy", config = RemoteSettingsConfig()),
                 collectionName = "nimbus-preview",
             ),
         ) as DummyNimbus

components/nimbus/tests/common/mod.rs

@@ -3,7 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 #![cfg(feature = "rkv-safe-mode")]
 
-use remote_settings::{RemoteSettingsConfig2, RemoteSettingsContext, RemoteSettingsService};
+use remote_settings::{RemoteSettingsConfig, RemoteSettingsContext, RemoteSettingsService};
 use rkv::StoreOptions;
 
 // utilities shared between tests
@@ -79,7 +79,7 @@ fn new_test_client_internal(
         ..Default::default()
     };
 
-    let config = RemoteSettingsConfig2 {
+    let config = RemoteSettingsConfig {
         server: Some(RemoteSettingsServer::Custom {
             url: url.as_str().to_string(),
         }),

components/nimbus/tests/test_fs_client.rs

@@ -8,7 +8,7 @@
 use std::sync::Arc;
 
 use nimbus::{error::Result, stateful::client::NimbusServerSettings};
-use remote_settings::{RemoteSettingsConfig2, RemoteSettingsContext, RemoteSettingsService};
+use remote_settings::{RemoteSettingsConfig, RemoteSettingsContext, RemoteSettingsService};
 
 mod common;
 
@@ -28,7 +28,7 @@ fn test_simple() -> Result<()> {
 
     let url = Url::from_file_path(dir).expect("experiments dir should exist");
 
-    let config = RemoteSettingsConfig2 {
+    let config = RemoteSettingsConfig {
         server: Some(RemoteSettingsServer::Custom {
             url: url.as_str().to_string(),
         }),

components/relay/src/rs.rs

@@ -298,11 +298,11 @@ impl RelayRemoteSettingsClient {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use remote_settings::{RemoteSettingsConfig2, RemoteSettingsServer};
+    use remote_settings::{RemoteSettingsConfig, RemoteSettingsServer};
 
     // Helper to create a RemoteSettingsService for testing
     fn create_test_remote_settings_service() -> Arc<RemoteSettingsService> {
-        let config = RemoteSettingsConfig2 {
+        let config = RemoteSettingsConfig {
             server: Some(RemoteSettingsServer::Custom {
                 url: "http://localhost".to_string(),
             }),