Allow any combination of channels in scanner query rules - #25312
Open
chrstinalin wants to merge 1 commit into
Open
Allow any combination of channels in scanner query rules#25312chrstinalin wants to merge 1 commit into
chrstinalin wants to merge 1 commit into
Conversation
chrstinalin
marked this pull request as draft
August 17, 2026 17:24
chrstinalin
force-pushed
the
#16299-enterprise-scanquery
branch
from
August 17, 2026 17:43
9944b60 to
7fc84ab
Compare
chrstinalin
force-pushed
the
#16299-enterprise-scanquery
branch
from
August 17, 2026 20:06
7fc84ab to
bb3571f
Compare
chrstinalin
marked this pull request as ready for review
August 17, 2026 20:44
chrstinalin
requested review from
a team and
eviljeff
and removed request for
a team
August 17, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes mozilla/addons#16299
Description
Testing
(Optional) Enable the
enterprise-channelwaffle switch. Create enterprise add-ons.Check out master.
Navigate to
admin/models/scanners/scannerqueryrule/add/. Create some rules with and withoutrun on specific channels.Check out the PR branch. Run the migration.
Existing rules should behave and display as expected.
Navigate back to
admin/models/scanners/scannerqueryrule/add/.Create a new rule: toggle
Run on specific channelsto true. Select some subset of channels. The rule's results should only show the expected channels.Create a new rule, leaving
Run on specific channelsset as false. By default, the rule runs on all channels.Create a new rule with specific channels set. Edit the rule and untoggle
Run on specific channels. Should default back to running on all channels.List view should correctly show which channels are being filtered to, if set.
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.