Skip to content

Allow any combination of channels in scanner query rules - #25312

Open
chrstinalin wants to merge 1 commit into
mozilla:masterfrom
chrstinalin:#16299-enterprise-scanquery
Open

Allow any combination of channels in scanner query rules#25312
chrstinalin wants to merge 1 commit into
mozilla:masterfrom
chrstinalin:#16299-enterprise-scanquery

Conversation

@chrstinalin

@chrstinalin chrstinalin commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Closes mozilla/addons#16299

Description

image image image

Testing

(Optional) Enable the enterprise-channel waffle switch. Create enterprise add-ons.

  1. Check out master.

  2. Navigate to admin/models/scanners/scannerqueryrule/add/. Create some rules with and without run on specific channels.

  3. Check out the PR branch. Run the migration.

  4. Existing rules should behave and display as expected.

  5. Navigate back to admin/models/scanners/scannerqueryrule/add/.

  6. Create a new rule: toggle Run on specific channels to true. Select some subset of channels. The rule's results should only show the expected channels.

  7. Create a new rule, leaving Run on specific channels set as false. By default, the rule runs on all channels.

  8. Create a new rule with specific channels set. Edit the rule and untoggle Run on specific channels. Should default back to running on all channels.

  9. List view should correctly show which channels are being filtered to, if set.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.

@chrstinalin
chrstinalin marked this pull request as draft August 17, 2026 17:24
@chrstinalin
chrstinalin force-pushed the #16299-enterprise-scanquery branch from 9944b60 to 7fc84ab Compare August 17, 2026 17:43
@chrstinalin
chrstinalin force-pushed the #16299-enterprise-scanquery branch from 7fc84ab to bb3571f Compare August 17, 2026 20:06
@chrstinalin
chrstinalin marked this pull request as ready for review August 17, 2026 20:44
@chrstinalin
chrstinalin requested review from a team and eviljeff and removed request for a team August 17, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Allow selecting a combination of channels scanner query rules run on

1 participant