📝 Add docstrings to feat/phase16-intelligent-ambient-npcs#4
Open
coderabbitai[bot] wants to merge 1 commit into
Open
📝 Add docstrings to feat/phase16-intelligent-ambient-npcs#4coderabbitai[bot] wants to merge 1 commit into
feat/phase16-intelligent-ambient-npcs#4coderabbitai[bot] wants to merge 1 commit into
Conversation
Docstrings generation was requested by @moyunzero. * #3 (comment) The following files were modified: * `apps/game-server/src/ambient/intent-cache.ts` * `apps/game-server/src/ambient/intent-fallback.ts` * `apps/game-server/src/ambient/schedule.ts` * `apps/game-server/src/ambient/segment-intent.ts` * `apps/game-server/src/ambient/tick.ts` * `apps/game-server/src/ambient/zone-wander.ts` * `apps/game-server/src/colyseus/bridge.ts` * `apps/game-server/src/colyseus/npc-chat.ts` * `apps/game-server/src/colyseus/server.ts` * `apps/game-server/src/colyseus/workerStateCache.ts` * `apps/game-server/src/index.ts` * `apps/game-server/src/queue/npc-ambient-intent.ts` * `apps/game-server/src/queue/npc-turn.ts` * `apps/game-server/src/room/executor.ts` * `apps/game-server/src/routes/chat.ts` * `apps/game-server/src/routes/internal-ambient-intent.ts` * `apps/game-server/src/routes/internal-memories.ts` * `apps/game-server/src/routes/internal.ts` * `apps/game-server/src/routes/rooms.ts` * `apps/game-server/src/sse/hub.ts` * `apps/game-server/src/world/region-walkability.ts` * `apps/game-server/src/world/registry-boot.ts` * `apps/web/src/ChatPage.tsx` * `apps/web/src/components/ExploreCoordsStrip.tsx` * `apps/web/src/components/MessageList.tsx` * `apps/web/src/components/PhaserGame.tsx` * `apps/web/src/game/activityLabelLogic.ts` * `apps/web/src/game/activityLabels.ts` * `apps/web/src/game/bgNpcLabels.ts` * `apps/web/src/game/entitySprites.ts` * `apps/web/src/game/floorBlocked.ts` * `apps/web/src/game/intentLabels.ts` * `apps/web/src/game/regionCollision.ts` * `apps/web/src/hooks/useColyseusRoom.ts` * `apps/web/src/hooks/useNpcChat.ts` * `apps/web/src/lib/chunkWalkability.ts` * `apps/web/src/lib/colyseusAmbientSnapshot.ts` * `apps/web/src/lib/speakLatencyTrace.ts` * `packages/shared/src/ambientIntentSchema.ts` * `packages/shared/src/backgroundNpc.ts` * `packages/shared/src/casualSpeakStub.ts` * `packages/shared/src/homeMap.ts` * `packages/shared/src/intentContent.ts` * `packages/shared/src/room.ts` * `packages/shared/src/speakIntent.ts` * `packages/shared/src/stableStringHash.ts` * `packages/shared/src/worldRegion.ts` * `scripts/bake-beginning-fields.mjs` * `scripts/bake-village-plaza.mjs` * `scripts/benchmark-speak-browser.mjs` * `scripts/e2e-full-run.mjs` * `scripts/lib/wait-for-stack.mjs` * `scripts/run-phase16-e2e.mjs` * `scripts/verify-phase16.mjs` * `workers/agent-worker/src/graph/action_intent.py` * `workers/agent-worker/src/graph/ambient_intent.py` * `workers/agent-worker/src/graph/casual_fast_lane.py` * `workers/agent-worker/src/graph/job_context.py` * `workers/agent-worker/src/graph/nodes/llm_social_turn.py` * `workers/agent-worker/src/graph/npc_loop.py` * `workers/agent-worker/src/graph/speak_intent.py` * `workers/agent-worker/src/graph/stable_string_hash.py` * `workers/agent-worker/src/main.py` * `workers/agent-worker/src/memory/client.py` * `workers/agent-worker/tests/test_ambient_intent.py` * `workers/agent-worker/tests/test_casual_fast_lane.py`
Author
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docstrings generation was requested by @moyunzero.
The following files were modified:
apps/game-server/src/ambient/intent-cache.tsapps/game-server/src/ambient/intent-fallback.tsapps/game-server/src/ambient/schedule.tsapps/game-server/src/ambient/segment-intent.tsapps/game-server/src/ambient/tick.tsapps/game-server/src/ambient/zone-wander.tsapps/game-server/src/colyseus/bridge.tsapps/game-server/src/colyseus/npc-chat.tsapps/game-server/src/colyseus/server.tsapps/game-server/src/colyseus/workerStateCache.tsapps/game-server/src/index.tsapps/game-server/src/queue/npc-ambient-intent.tsapps/game-server/src/queue/npc-turn.tsapps/game-server/src/room/executor.tsapps/game-server/src/routes/chat.tsapps/game-server/src/routes/internal-ambient-intent.tsapps/game-server/src/routes/internal-memories.tsapps/game-server/src/routes/internal.tsapps/game-server/src/routes/rooms.tsapps/game-server/src/sse/hub.tsapps/game-server/src/world/region-walkability.tsapps/game-server/src/world/registry-boot.tsapps/web/src/ChatPage.tsxapps/web/src/components/ExploreCoordsStrip.tsxapps/web/src/components/MessageList.tsxapps/web/src/components/PhaserGame.tsxapps/web/src/game/activityLabelLogic.tsapps/web/src/game/activityLabels.tsapps/web/src/game/bgNpcLabels.tsapps/web/src/game/entitySprites.tsapps/web/src/game/floorBlocked.tsapps/web/src/game/intentLabels.tsapps/web/src/game/regionCollision.tsapps/web/src/hooks/useColyseusRoom.tsapps/web/src/hooks/useNpcChat.tsapps/web/src/lib/chunkWalkability.tsapps/web/src/lib/colyseusAmbientSnapshot.tsapps/web/src/lib/speakLatencyTrace.tspackages/shared/src/ambientIntentSchema.tspackages/shared/src/backgroundNpc.tspackages/shared/src/casualSpeakStub.tspackages/shared/src/homeMap.tspackages/shared/src/intentContent.tspackages/shared/src/room.tspackages/shared/src/speakIntent.tspackages/shared/src/stableStringHash.tspackages/shared/src/worldRegion.tsscripts/bake-beginning-fields.mjsscripts/bake-village-plaza.mjsscripts/benchmark-speak-browser.mjsscripts/e2e-full-run.mjsscripts/lib/wait-for-stack.mjsscripts/run-phase16-e2e.mjsscripts/verify-phase16.mjsworkers/agent-worker/src/graph/action_intent.pyworkers/agent-worker/src/graph/ambient_intent.pyworkers/agent-worker/src/graph/casual_fast_lane.pyworkers/agent-worker/src/graph/job_context.pyworkers/agent-worker/src/graph/nodes/llm_social_turn.pyworkers/agent-worker/src/graph/npc_loop.pyworkers/agent-worker/src/graph/speak_intent.pyworkers/agent-worker/src/graph/stable_string_hash.pyworkers/agent-worker/src/main.pyworkers/agent-worker/src/memory/client.pyworkers/agent-worker/tests/test_ambient_intent.pyworkers/agent-worker/tests/test_casual_fast_lane.pyThese files were kept as they were
workers/agent-worker/tests/test_action_intent.pyworkers/agent-worker/tests/test_casual_reply_pool.pyThese files were ignored
apps/game-server/src/ambient/intent-cache.test.tsapps/game-server/src/ambient/intent-fallback.test.tsapps/game-server/src/ambient/schedule.test.tsapps/game-server/src/ambient/segment-intent.test.tsapps/game-server/src/ambient/tick.test.tsapps/game-server/src/ambient/zone-wander.test.tsapps/game-server/src/colyseus/bridge.test.tsapps/game-server/src/colyseus/npc-chat.test.tsapps/game-server/src/index.test.tsapps/game-server/src/queue/npc-ambient-intent.test.tsapps/game-server/src/room/executor.test.tsapps/game-server/src/speak/casual-stub.test.tsapps/game-server/src/sse/hub.colyseus.test.tsapps/game-server/src/world/chunk-loader.test.tsapps/game-server/src/world/cross-region.test.tsapps/game-server/src/world/lore-repository.test.tsapps/game-server/src/world/region-walkability.test.tsapps/web/src/components/MessageList.test.tsapps/web/src/game/RoomScene.activity.test.tsapps/web/src/game/bgNpcLabels.test.tsapps/web/src/game/floorBlocked.test.tsapps/web/src/hooks/useNpcChat.test.tsapps/web/src/lib/colyseusAmbientSnapshot.test.tspackages/shared/src/intentContent.test.tspackages/shared/src/npcActivity.test.tspackages/shared/src/room.test.tspackages/shared/src/speakIntent.test.tspackages/shared/src/worldRegion.test.tsThese file types are not supported
.gitignoreapps/game-server/data/schedules/README.mdapps/game-server/data/schedules/npc-1.jsonapps/game-server/data/schedules/npc-2.jsonapps/game-server/data/schedules/npc-3.jsonapps/game-server/data/schedules/schema.jsonapps/game-server/data/world/beginning-fields@v1/collision.jsonapps/game-server/data/world/beginning-fields@v1/pois.jsonapps/game-server/data/world/beginning-fields@v1/spawns.jsonapps/game-server/data/world/beginning-fields@v1/zones.jsonapps/game-server/data/world/regions.jsonapps/game-server/data/world/village-plaza@v1/collision.jsonapps/game-server/data/world/village-plaza@v1/pois.jsonapps/game-server/data/world/village-plaza@v1/spawns.jsonapps/game-server/data/world/village-plaza@v1/zones.jsonapps/game-server/src/ambient/README.mdapps/web/public/assets/one-city/BeginningFields.jsonapps/web/public/maps/village-plaza/v1.jsonapps/web/public/world/beginning-fields/collision.jsonapps/web/public/world/village-plaza/collision.jsonapps/web/src/index.cssdocs/CONTRACTS.mddocs/LLM-E2E-FLOW-AND-LATENCY.mdpackage.jsonℹ️ Note