Initialize grasp_frame_transform to Identity in MTC tutorial#1090
Open
remete618 wants to merge 1 commit intomoveit:mainfrom
Open
Initialize grasp_frame_transform to Identity in MTC tutorial#1090remete618 wants to merge 1 commit intomoveit:mainfrom
remete618 wants to merge 1 commit intomoveit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grasp_frame_transformtoEigen::Isometry3d::Identity()in both the tutorial source code and the RST code blockWhat changed
Two files:
src/mtc_node.cpp(line 191)pick_and_place_with_moveit_task_constructor.rst(line 699)The original code set rotation via quaternion but never initialized the translation.
Identity()zeroes the translation and sets rotation to identity before the quaternion assignment overwrites the rotation.Test plan