Skip to content

Initialize grasp_frame_transform to Identity in MTC tutorial#1090

Open
remete618 wants to merge 1 commit intomoveit:mainfrom
remete618:fix/mtc-grasp-frame-transform-init
Open

Initialize grasp_frame_transform to Identity in MTC tutorial#1090
remete618 wants to merge 1 commit intomoveit:mainfrom
remete618:fix/mtc-grasp-frame-transform-init

Conversation

@remete618
Copy link
Copy Markdown

Summary

What changed

Two files:

  • src/mtc_node.cpp (line 191)
  • pick_and_place_with_moveit_task_constructor.rst (line 699)
// Before (uninitialized, translation component contains garbage values)
Eigen::Isometry3d grasp_frame_transform;

// After
Eigen::Isometry3d grasp_frame_transform = Eigen::Isometry3d::Identity();

The original code set rotation via quaternion but never initialized the translation. Identity() zeroes the translation and sets rotation to identity before the quaternion assignment overwrites the rotation.

Test plan

  • Tutorial code compiles
  • RST code block matches source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MTC Pick and Place tutorial uses uninitialised value for grasp_frame_transform

1 participant