Pass through errors when deserialization fails in NodeState#2292
Merged
milesj merged 5 commits intomoonrepo:masterfrom Jan 13, 2026
Merged
Conversation
added 2 commits
January 8, 2026 22:10
Adjective-Object
commented
Jan 8, 2026
| Ok(result.config) | ||
| } | ||
|
|
||
| #[cfg(feature = "proto")] |
Contributor
Author
There was a problem hiding this comment.
this method references types from proto_core, when proto_core is not in the build graph unless the proto feature flag is turned on
Adjective-Object
commented
Jan 8, 2026
| moon_toolchain_plugin = { path = "../toolchain-plugin" } | ||
| moon_vcs = { path = "../vcs" } | ||
| moon_workspace_graph = { path = "../workspace-graph" } | ||
| proto_core = { workspace = true } |
Contributor
Author
There was a problem hiding this comment.
This package references proto_core but never lists it as a dependency
This was referenced Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
At present, whenever deserialization fails for a
Package, the deserialization error is swallowed and replaced withdata did not match any variant of untagged enum NodeState.Solution & Changes
This change is inspired by serde_untagged, and implements a custom deserializer for NodeState that forwards all non-empty serde types to the inner type + returns the inner type's deserializer errors.
This change contains 2 commits:
893be7441fab413f7e5a537c627d17a9f4b4997bperforms the actual workbd87e312f5464a819a230253eef04a19781d0f01adds some missing cfg() and dependencies related toproto_core, which were causing test runs to failSee: #2201.