Refer to time-related constants and intended use.#1584
Merged
andrewnicols merged 1 commit intomoodle:mainfrom May 6, 2026
Merged
Refer to time-related constants and intended use.#1584andrewnicols merged 1 commit intomoodle:mainfrom
andrewnicols merged 1 commit intomoodle:mainfrom
Conversation
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds guidance to the Time subsystem documentation clarifying how Moodle’s time-related constants should (and should not) be used when working with relative time, aligning with MDLSITE-3967.
Changes:
- Introduces a new “Relative time” section describing intended use of time-related constants for UI options.
- Recommends using PHP
\DateTimeclasses (e.g.\DateTimeImmutable) for relative-time calculations to handle leap years/DST correctly.
andrewnicols
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://moodle.atlassian.net/browse/MDLSITE-3967