feat: gallery video duration#153
Draft
shimeoki wants to merge 1 commit intomonogram-android:developfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #136
works for videos under an hour, but i was unable to test it on long videos for some reason.
both official telegram client and monogram refuse to index these files. official telegram application shows them as "00:00" in duration, and monogram doesn't show the duration at all - the duration is probably 0 in this case.
i don't know how the app should behave in this scenario (show zero duration, don't show duration, show unknown duration), so i am marking this as a draft for now. if we need to distinguish between zero duration and non-videos, then default duration should be set to a negative value