Add VPN auto-disable feature for proxy settings#121
Open
SEVENID wants to merge 2 commits intomonogram-android:developfrom
Open
Add VPN auto-disable feature for proxy settings#121SEVENID wants to merge 2 commits intomonogram-android:developfrom
SEVENID wants to merge 2 commits intomonogram-android:developfrom
Conversation
Member
|
Add translations of other languages + check for connection via intent https://github.com/monogram-android/monogram/blob/develop/app/src/main/java/org/monogram/app/MainContent.kt#L134-L221 |
SEVENID
force-pushed
the
feat/vpn-auto-disable
branch
from
52dfbab to
37944e9
Compare
Author
|
Seems ready. Please recheck. |
Member
|
No need to touch modules in gradle the project was deliberately divided into modules data module should not be imported into presentation |
SEVENID
force-pushed
the
feat/vpn-auto-disable
branch
2 times, most recently
from
a8a212c to
663d4d0
Compare
- VpnDetector: NetworkCallback-based VPN status detection with debounced checks and idempotent startMonitoring - ConnectionManager: VPN monitoring flow that auto-disables proxy when VPN is active and restores on disconnect - ConnectionManager: VPN guard on selectBestProxy() (double check) and eager proxy enable on init - ConnectionManager: VPN guard on reconnect attempts (runReconnectAttempt) to skip TDLib calls while VPN active - ConnectionManager: close() method for full lifecycle cleanup (jobs, callbacks, VpnDetector) - ConnectionManager: ProxyModeState data class replacing nested tuples in combine flow - Proxy UI: VPN auto-disable toggle in settings screen with Shield icon - Proxy UI: VPN warning text in proxy confirmation dialog with conditional 'Save for Later' button - ProxyComponent: sealed EnableProxyResult (Enabled/Skipped/Error) for clear proxy enable outcomes - ProxyComponent: extracted vpnBlockActive property and showVpnBlockToast() helper to reduce duplication - Persistent savedProxyBeforeVpn preference survives process death - Type-safe getSystemService calls in dataModule - Translations: EN/RU/UK/ZH/SK for all VPN-related strings
SEVENID
force-pushed
the
feat/vpn-auto-disable
branch
from
663d4d0 to
fb9d944
Compare
gdlbo
requested changes
Apr 5, 2026
Member
gdlbo
left a comment
gdlbo
left a comment
There was a problem hiding this comment.
Overall good, but the components in MainContent should be separated into a separate components folder
Member
There was a problem hiding this comment.
In general, you need to split the code into components and move it to app/components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
100% vibecoded with qwen3.5 and opencode. Build successful, new checkbox seems to work but please review first.
Screenshot: