Skip to content

fix: prevent scrolling in modals to scroll the main page (@fehmer) #8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fehmer wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −1
Open

fix: prevent scrolling in modals to scroll the main page (@fehmer) #8173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1afd2f
fix: prevent scrolling in modals to scroll the main page (@fehmer)
fehmer Jun 29, 2026
4a24ed3
old modals
fehmer Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/src/styles/core.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ main {
scrollbar-color: var(--sub-color) transparent;
}

.modal {
overscroll-behavior-y: none;
}

html {
@extend .ffscroll;
overflow-y: scroll;
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/ts/components/common/AnimatedModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ export function AnimatedModal(props: AnimatedModalProps): JSXElement {
>
<div
class={cn(
"modal pointer-events-auto grid h-max max-h-full w-full max-w-md gap-4 overflow-auto rounded-double bg-bg p-4 text-text ring-4 ring-sub-alt sm:p-8",
"modal pointer-events-auto grid h-max max-h-full w-full max-w-md gap-4 overflow-auto overscroll-y-none rounded-double bg-bg p-4 text-text ring-4 ring-sub-alt sm:p-8",
props.modalClass,
)}
ref={modalRef}
Expand Down
Loading