-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
refactor: solid keymap (@fehmer) #8134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fehmer
wants to merge
68
commits into
master
Choose a base branch
from
feature/solid-keymap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,855
−1,441
Open
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
f2da7f0
wip
fehmer b570b60
converter
fehmer eb64bb2
wip
fehmer ee7ef37
simplify
fehmer 4651c5f
format test
fehmer 3111196
change keymapShowTopRow to keymapLayoutStyle
fehmer 8e611ca
fix bottom row
fehmer 731b7bf
iso
fehmer 55ff0a6
simplify test
fehmer 08a52d3
matrix
fehmer 6e9ae08
fix reactivity, matrix tests
fehmer dab0856
wip
fehmer c2b035f
update x-offset to be in u instead of 1/4 u
fehmer ed86336
highlight next key, add homing, fix layoutIndicator
fehmer d2324f3
Merge branch 'master' into feature/solid-keymap
fehmer 07d8c68
fix indicator text color
fehmer b88156f
fix tab navigation
Miodec f076ec7
add animations
Miodec 507f998
add steno
fehmer 46015f6
extract wordsHaveNumbers signal. show numrow if test has numbers on n…
fehmer 0da7483
fix next, restructure tests
fehmer 6eadde4
handle row5 with two keys, fix flash issue
fehmer 4e79190
move
fehmer ce634f2
dont shift numrow on mac
fehmer 3e55843
refactor
fehmer 2595877
extract findLayoutIndicatorIndex
fehmer d86b114
refactor extra keys
fehmer b326179
custom gaps, better types, rename col1Gap
fehmer 520a8c5
rename
fehmer 4836812
minoor tweaks
fehmer b305e18
rotation
fehmer 84f21de
alice, wip
fehmer 2bb9db4
single signal for flash key
fehmer e1a3bca
cleanup, move event listeners to states
fehmer 4cdacc9
fix fadein on load+ numrow display
fehmer 41791de
alice y values
Miodec 1c18e55
use map instead of if
fehmer d6c473b
new approach
fehmer 3154245
use array of arrays to support more rows
fehmer 434782e
remove dynamic row5, remove matrix layout type, cleanup loop
fehmer 48d6f48
unknown keys
fehmer df5c848
steno and steno matrix
fehmer 59652d4
add split
fehmer 3480564
matrix and split matrix
fehmer 174fdbc
alice
fehmer cac0e71
remove structuredClone, we don't modify the layout anymore
fehmer e6a4e48
optimise flashState by using store, extract to states
fehmer 683f37f
useListener
fehmer 2548f0d
layout from single source
fehmer d8b1762
remove leftover from alt/shift tracker
fehmer e10b422
Merge branch 'master' into feature/solid-keymap
fehmer 1045372
showw all case if extra keys are needed, swedish use-case
fehmer b6b626d
optimize react
fehmer 7fc7944
center keymap, apply zoom
fehmer 573b1b4
out with the old, test fix
fehmer 2a6e7eb
cleanup
fehmer d8d4d0f
reduce size
Miodec ef0c094
Merge branch 'master' into feature/solid-keymap
fehmer 22e2f73
fix x offsets, bit better alice layout
fehmer 8396553
alice homing key
fehmer 99e1138
await keymap
fehmer 8900415
fix tests
fehmer 32ae0c0
homing indicator
fehmer 9ef09f0
trigger
fehmer b2aeeca
Merge branch 'master' into feature/solid-keymap
fehmer a468d13
review comments
fehmer 9fb3793
2 review 2 comments
fehmer 37aa7db
don't show base layer on alt-layers
fehmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { readFileSync } from "fs"; | ||
| import { resolve } from "path"; | ||
| import { fileURLToPath } from "url"; | ||
| import { vi } from "vitest"; | ||
|
|
||
| const BASE_DIR = resolve(fileURLToPath(import.meta.url), "../../../static"); | ||
|
|
||
| async function readJson<T>(filePath: string): Promise<T> { | ||
| const fullPath = resolve(BASE_DIR, filePath.replace(/^\//, "")); | ||
| const data = readFileSync(fullPath, "utf-8"); | ||
| return JSON.parse(data) as T; | ||
| } | ||
|
|
||
| vi.mock("../../src/ts/utils/json-data", async (importOriginal) => { | ||
| const original = (await importOriginal()) as any; | ||
|
|
||
| // oxlint-disable-next-line typescript/no-unsafe-return | ||
| return { | ||
| ...original, | ||
| getLayout: async (name: string) => readJson(`/layouts/${name}.json`), | ||
| }; | ||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope