-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
refactor: solid header (@miodec, @fehmer) #7564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 72 commits
Commits
Show all changes
154 commits
Select commit
Hold shift + click to select a range
ba76e7b
rework mounting
Miodec 2d93af6
string
Miodec f0b0888
revert
Miodec ca6d9eb
move footer
Miodec af178d7
WIP
Miodec 80463ad
Merge commit '39245bc92fb47c258d19896b9f5ad8d0ccf1aa09' into solid-nav
Miodec 9d49dc0
wip, handle some buttons, add bubble signal
Miodec bf63532
chore: use signal instead of modifying the dom directly
Miodec 7ae32fd
Merge branch 'master' into solid-nav
Miodec 2aa21ea
wip
Miodec 63970af
aaa
Miodec af87938
WIP
Miodec 6acbc51
motion
Miodec 0b39746
Merge branch 'master' into solid-nav
Miodec 11120a9
Merge branch 'master' into solid-nav
Miodec f5b8b83
switch to anime, use discord avatar
Miodec 839b9a3
Merge branch 'master' into solid-nav
Miodec 3c02b8a
fix merge
Miodec cfaecb0
wip
Miodec f52956e
wip
Miodec 016945e
wip
Miodec acf5079
flags
Miodec 149f270
refactor
Miodec 4eba170
fix
Miodec 06f1e46
default animaeprops
Miodec 4de0237
comments
Miodec 0dcd895
menu
Miodec 628896a
update User component to conditionally hide name on small screens and…
Miodec 5fec65e
styling
Miodec 2142f65
remove focus class from header
Miodec c98e122
style
Miodec 05a99f0
hide friends when not enabled
Miodec 8b13cb2
wip
Miodec 85f5f6f
first version
Miodec 1c66e6a
ya boi
Miodec 4eab29e
almost done
Miodec a0a3970
rework
Miodec 03b96e7
cleanup
Miodec dd87c5e
fix anim
Miodec bdb7e83
fixes
Miodec 2799bfd
fire in sync
Miodec 09fa036
fix menu
Miodec 0e551ec
fancy hook
Miodec d08e511
add direct setter to hook
Miodec 56a93fb
use currying
Miodec 2ec9276
dont flash on mount
Miodec 0ae1c4c
hide menu if snapshot is undefined
Miodec 57d3221
lift state
Miodec 9458543
refactor: simplify XP addition by using addXp function with breakdown
Miodec bdd8955
event design
Miodec 97028a3
use create event
Miodec ff7c5d3
Merge branch 'master' into solid-nav
Miodec 3d1ca06
move to dev options
Miodec ee8bf87
clear styles after animation, remove transition for the duration of t…
Miodec ea2de40
forward class, animations
Miodec 8c262aa
cleanup
Miodec 438b248
bubbles
Miodec 0213f49
cleanup
Miodec e706152
Merge branch 'master' into solid-nav
Miodec 07e1267
cleanup, todos
Miodec dcce2b3
Merge branch 'master' into solid-nav
Miodec 28b515b
Merge branch 'master' into solid-nav
Miodec 835d2b5
fix merge
Miodec 94e80c0
cleanup
Miodec 5777c97
remove
Miodec 44349bd
comment
Miodec 58eddc8
comment
Miodec d62f256
commnents
Miodec 9af6d20
comment
Miodec 534dce8
comment
Miodec 3dfe5cb
comment
Miodec 1a3c7eb
missing onclick
Miodec 890d30a
fix
Miodec 85940d3
move menu down
Miodec 21ca3cb
derive alerts bubble from snapshot
Miodec 57bd2a3
merge signal files
Miodec baa2cd8
prefetch
Miodec 8431bb8
path fix
Miodec 7fd9213
remove comments
Miodec 70dbd95
refactor: enhance Conditional and AnimeConditional components for bet…
Miodec 4f0da88
dont show breakdown if user left result page by the time it saved
Miodec 97857a6
better prefetch
Miodec 5a18e5f
reorder
Miodec 990dd3d
h1
Miodec 65d52e7
rework level
Miodec 6b08f81
Merge branch 'master' into solid-nav
Miodec f115ae6
fix logo text hiding, allow theme to maintain buttons on focus
fehmer 1d245d2
some fixes
fehmer d3cc050
fix chaos theory
Miodec 706fbc9
fix hover
Miodec c3b26be
restructure
Miodec 718932a
parent props
Miodec dd738b3
Merge branch 'master' into solid-nav
Miodec 8ead973
move ui-element notificationBubble to all notificationBubbles
fehmer 711d8b1
rename
Miodec f4f45ed
fix incorrect dataset
Miodec 165e31b
move chaos theory caret image to the repo
fehmer cdec979
fix trance
Miodec c50a0e8
fix
Miodec 462ec2b
fix terrazzo
Miodec 73e78fa
add hover effect to themes using background nav items
fehmer ce022de
fix suisei
Miodec f571a35
fixx
Miodec cc2eadc
use nesting
fehmer ee989ed
remove footer styling from chaos, add nav hover to 9009
fehmer 4f255e5
add hover to aether, fix logo of aurora
fehmer cdd99f0
use currentColor for discord svg and logo, fix bingsu and catppuccin
fehmer 5a8dfba
fix dark note
fehmer 7b542f7
fixes
fehmer 8dbfe4f
fix dots
fehmer 739b511
fixes
fehmer 76e2cee
logo
Miodec 9d425fa
fix nav avatar
Miodec 3be7496
fixes
fehmer 7b9fd2e
uneless
Miodec f7d0931
data focused
Miodec 54688dc
snes
Miodec a01af63
replace, shadow
Miodec b551960
current color logo
Miodec c42e0ba
half-fix incognito
fehmer 3e27d8c
lavender
fehmer 1cadc05
milkshake
fehmer 64d0a4c
modern ink
fehmer 01ae9c2
moonlight
fehmer d521f56
sewing tin
Miodec fb5e330
rgb
Miodec 0207d69
rainbow trail
Miodec b3f100b
phantom
Miodec f59cf8d
fix clippig
Miodec 2b77bf7
some fixes§§
fehmer c915239
clenaup
fehmer 2251d42
fix lsd
Miodec 139598f
fix menu
Miodec 0075ae1
fix nav buttons lacking transition
Miodec d0d7dc6
add button variant, data prop
Miodec 3d96ffa
fix logo color
Miodec 9557ab2
fix themes
Miodec c43a3f6
fix terazzo
fehmer 3dab6c2
themes
Miodec 8077caf
new approach to buttons
Miodec 299881a
fix
Miodec ff2e6f3
fix themes
Miodec 1cb2419
fix focus
Miodec e5515e5
yeet classlist
Miodec 98bbd4b
active is handled by modifying css variable now
Miodec 36c8d65
fix
Miodec 3f5edd4
Update frontend/src/ts/components/layout/header/AccountMenu.tsx
Miodec 7895395
Update frontend/src/ts/components/layout/header/AccountXpBar.tsx
Miodec d1d7073
Update frontend/src/ts/components/layout/header/Nav.tsx
Miodec 11e8382
fix
Miodec 664c76c
css approach
Miodec b995adc
remove dead signal, review comments
Miodec 812a9f8
missing return to 0
Miodec bece36c
fix
Miodec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,10 +14,4 @@ | |
| display: none; | ||
| } | ||
| } | ||
| header { | ||
| gap: 0.25rem; | ||
| nav .textButton { | ||
| padding: 0.5em 0.25em; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config tests previously asserted the account spinner/loading toggling during debounced saves. That coverage was removed when migrating off
AccountButton.loading(...). Consider replacing it with an assertion on the new mechanism (e.g. spy onsetAccountButtonSpinnerfromsignals/header) so regressions in spinner behavior are still caught.