fix(tags): Update tags after deletion (@Leonabcd123)

[Leonabcd123]

Description

Fixes the following bug:

• Create tag
• Go to account page
• Add that tag to some result
• Delete the tag
• Go back to account page
• Notice that it still thinks that the test has a tag

[github-actions]

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

[Copilot]

Pull request overview

This PR fixes a bug where deleted tags remained referenced in test results. When a user deleted a tag and returned to the account page, the test results would still show the deleted tag as associated with them.

Changes:

• Added deleteLocalTag function to remove tag references from all results in the snapshot
• Integrated the cleanup function into the tag deletion flow to ensure results are updated when tags are deleted

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
frontend/src/ts/db.ts	Added deleteLocalTag function that iterates through all results and removes references to the deleted tag
frontend/src/ts/modals/edit-tag.ts	Integrated call to deleteLocalTag in the tag removal modal's execution flow

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The function is declared as async but doesn't contain any asynchronous operations. Consider removing the async keyword to accurately reflect the function's synchronous nature. This would also allow callers to use it without await.

Suggested change

	export async function deleteLocalTag(tagId: string): Promise<void> {
	export function deleteLocalTag(tagId: string): void {

[Copilot]

Consider calling deleteLocalTag before Settings.update() to ensure the snapshot is fully cleaned up before the UI is updated. This would make the state consistent at the time Settings.update() reads it.

Suggested change

	void Settings.update();
	await DB.deleteLocalTag(tagId);
	await DB.deleteLocalTag(tagId);
	void Settings.update();

[Copilot]

Consider adding test coverage for the deleteLocalTag function to verify it correctly removes tag references from all results. This would help prevent regressions of the bug being fixed here.