refactor: move event handlers from simple-modals to respective files (@biplavbarua)

[biplavbarua]

This PR addresses the TODO in simple-modals.ts by moving event handlers to their respective page controller files (account-settings.ts and settings.ts).

Key Changes:

1. Moved .pageAccountSettings handlers to account-settings.ts.
2. Moved .pageSettings handlers to settings.ts.
3. Extracted PopupKey, list, and showPopup to simple-modals-base.ts to resolve circular dependencies introduced by importing page controllers in simple-modals.ts (which now import showPopup from base).

Testing:

• Verified no circular dependencies with madge.
• Verified type safety with tsc.
• Verified build success.

[Copilot]

Pull request overview

This PR refactors the codebase by moving event handlers from simple-modals.ts to their respective page controller files (account-settings.ts and settings.ts) and extracts shared utilities to a new simple-modals-base.ts file to prevent circular dependencies.

Changes:

• Created simple-modals-base.ts to export PopupKey, list, and showPopup function
• Moved event handlers for account-related buttons from simple-modals.ts to account-settings.ts
• Moved event handlers for settings-related buttons from simple-modals.ts to settings.ts

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
frontend/src/ts/modals/simple-modals-base.ts	New file containing extracted PopupKey type, list object, and showPopup function to prevent circular dependencies
frontend/src/ts/modals/simple-modals.ts	Removed event handlers and showPopup function; now imports and re-exports from simple-modals-base.ts
frontend/src/ts/pages/account-settings.ts	Added event handlers for account-related buttons and imported showPopup from simple-modals-base.ts
frontend/src/ts/pages/settings.ts	Added event handlers for settings-related buttons (custom themes and fonts) and imported showPopup from simple-modals-base.ts

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[biplavbarua]

Refactored event handlers based on Copilot feedback:\n- Moved #resetSettingsButton handler to settings.ts.\n- Moved #bannerCenter handler to simple-modals.ts.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Miodec]

Thanks!