-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5668 - Merge backpressure branch into mainline #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
340 commits
Select commit
Hold shift + click to select a range
725dbc2
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 54fd7b6
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 1603122
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 6fc8bdd
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 5a71892
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 1418c90
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7da2c35
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 91e6089
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 220649d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 865cecd
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 fc6ce2a
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 071d09e
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 4e84bd4
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 bf9452b
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 bd12579
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7ad6215
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 d952970
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 01733cf
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 8395c8b
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 be9cbd1
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 fd4049b
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 04fc9a5
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 2ed2498
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 b1dcfbe
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 8d7c96f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 24b7c2f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 0ed2438
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 31800c7
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7827fa9
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 8ce09cf
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 14bdd27
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 f938358
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 5662f2e
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 b4fedd5
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 874f623
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 a0d9140
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 55eb2f1
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 6a12533
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9349d90
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 cf909aa
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7eafd5d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 cb075e5
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 5bef533
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 564527c
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 82978f9
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9f40142
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 87bc432
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 516ec00
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 c14943a
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 edb5419
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 ffa3d0d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 32168e9
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 715a56d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 35698e0
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 47db389
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 5321aa8
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 a595e39
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 85b7090
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 524686a
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7b2a009
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 840cfac
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 3d11495
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 62ffa2c
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 0ce7e7d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 e143f47
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 082e1a4
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 88ea6ff
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 dc4373d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 382415f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9cdf369
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 89984e1
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9babce9
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 2329f91
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 fc3ce9d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 3330ee0
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 e133da5
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7814f1a
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 b36b254
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 e69ee19
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 5ac2a91
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 efc08b2
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 0609631
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 464bcde
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 2e6201d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 b431154
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 e296cf9
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 230dd08
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 ceb2bde
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 75d9623
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9fe7359
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 71ceb58
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 789a10f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 bab9849
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 1d39d87
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 8d3d31d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 14b57b0
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 e3b7a2e
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 3b6ab84
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 28dded8
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7970871
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 d870f6d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 317a991
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 d288759
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 fdef122
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 dbf2bda
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9bd25fb
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 a99ec0e
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 a573ba0
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 6f330ae
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 63c3739
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 3feb663
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 d77e8ab
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 0fbfba7
Mt erge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 47f5804
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 67bb82a
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 f016e85
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 5d67dbc
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 cecaa7f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 88e5df5
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 8685f59
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 51292de
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 8c39812
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 c0d5220
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 011969a
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 0dece2f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 51afaa8
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 536a20e
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 56f7268
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 50d9b26
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 ecd548f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 efc53e3
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 33922d4
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 cee3e61
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7ae2d95
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9569a35
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 6540681
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 60ad013
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 b52c46e
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 da0d5ec
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 87a6ca6
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 755c1b5
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 0634cef
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 e9744f2
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 1b4de22
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 0d3c471
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 c5ca1f2
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 39559d6
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9768a05
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 953c06d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 ccc5dfc
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 2a80cda
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 beee2ec
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 684a5ab
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 bf34fa0
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 826ebef
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 563f98d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 3676c37
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 1858879
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 4cd2a64
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 c69de56
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 354b166
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 c1f91b8
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 888abc7
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 d406616
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 d07301e
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 a54d9d0
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 d6b3865
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 87876b5
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 c954174
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 c1c84b2
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7a34a46
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 2df1cf9
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 8eab432
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 74ec258
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 a0994a5
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 56affb4
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 8236904
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 bd33b8d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 1370dee
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 e334c4f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 41a760d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 d04c4b9
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 da2d09b
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 d59f20a
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 1754bbe
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7edf68f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 b59039b
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 26542db
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 daf0f89
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 67a2e17
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 fa821ac
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 efd833b
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 222877c
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7529979
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9c6f82d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7ae185a
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 ca59c31
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 a291fd0
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 30d1c7f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 a216788
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 6ce1501
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 e91b817
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 c0d6244
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 389f4cb
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 8082ca0
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 af18e5f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 7dc4a8d
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 b830ef0
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 6bf7615
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9e113e7
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 4ce19a1
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 d3da880
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 90923df
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 c0b5191
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 41c61a6
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 6c293df
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 5071487
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9cc1a55
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 9ec841f
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 145cade
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 ed3a974
Merge branch 'master' of github.com:mongodb/mongo-python-driver
blink1073 c6526f8
PYTHON-5504 Prototype exponential backoff in with_transaction (#2492)
ShaneHarvey 0010325
PYTHON-5536 Avoid clearing the connection pool when the server connec…
blink1073 d767759
PYTHON-5517 update SDAM error handling tests to ignore handshake fail…
blink1073 88f05fa
PYTHON-5518: withTransaction API retries too frequently (#2600)
sleepyStick e1249d0
PYTHON-5675 Fix Backpressure-related racy tests (#2653)
blink1073 84699d2
Merge branch 'master' of github.com:mongodb/mongo-python-driver into …
blink1073 27a9f47
PYTHON-5696 Fix racy backpressure-network tests (#2678)
blink1073 8dbf903
PYTHON-5528 & PYTHON-5651 Add exponential backoff to operation retry …
blink1073 9c70be4
Merge branch 'master' of github.com:mongodb/mongo-python-driver into …
blink1073 1d219a9
PYTHON-5695 Clarify NoWritesPerformed error label behavior when multi…
blink1073 e7a5247
PYTHON-5528 - Token buckets disabled by default (#2713)
NoahStapp 359ddfa
PYTHON-5741 - Transaction state is preserved across retries (#2718)
NoahStapp cc5b9c4
PYTHON-5716 - Clarify expected error if backoff exceeds CSOT's deadli…
NoahStapp 0a47a19
PYTHON-5752 - Only retry overload errors if retries are enabled (#2726)
NoahStapp 3724303
Merge branch 'master' into backpressure
NoahStapp a7fc68f
SH + CP review
NoahStapp 3f64de3
PYTHON-5743 + PYTHON-5755 sync (#2735)
NoahStapp 02320d6
PYTHON-5767 - Finalize client backpressure implementation for phase 1…
NoahStapp d864822
PYTHON-5788 - Refine withTransaction timeout error wrapping semantics…
NoahStapp 863704e
Merge branch 'master' into backpressure
NoahStapp 0948cdf
CP review
NoahStapp 260c829
Update doc/changelog.rst
NoahStapp 284dfa2
CP review
NoahStapp 2bf2502
CP review
NoahStapp 30ccd77
Merge branch 'master' into backpressure
NoahStapp 49302f9
AC + CP review
NoahStapp 02201d2
AC review
NoahStapp 065e282
AC review
NoahStapp b658cbd
Remove PYTHON-5668.patch
NoahStapp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think PYTHON-5668.patch can be removed too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! At long last