Open
Conversation
It was only used in `bulkwrite_get_debug_info`, where we could really just instantiate the `WriteConcern` instance and add that to the debug info, which would result in the `WriteConcern` object being var_dumped and it more in line with what you'd expect as a PHP user anyway.
paulinevos
requested review from
GromNaN and
Copilot
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR removes the internal helper phongo_write_concern_to_zval() and updates MongoDB\Driver\BulkWrite debug output to expose the write concern as a MongoDB\Driver\WriteConcern object (instead of an array), aligning var_dump() output with user expectations.
Changes:
- Removed
phongo_write_concern_to_zval()from the WriteConcern header and implementation. - Updated
BulkWritedebug info generation to instantiate aWriteConcernobject viaphongo_writeconcern_init(). - Updated the PHPT expectation to match the new
var_dump()structure.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/bulk/write-0002.phpt | Updates expected var_dump() output for BulkWrite to show a WriteConcern object. |
| src/MongoDB/WriteConcern.h | Removes the declaration of the now-unused helper function. |
| src/MongoDB/WriteConcern.c | Removes the implementation of phongo_write_concern_to_zval(). |
| src/MongoDB/BulkWrite.c | Switches debug info write concern from array serialization to a WriteConcern object instance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was only used in
bulkwrite_get_debug_info, where we could really just instantiate theWriteConcerninstance and add that to the debug info, which would result in theWriteConcernobject being var_dumped and it more in line with what you'd expect as a PHP user anyway.