Add Javadoc to specify that CSOT does not limit socket writes#1791
Merged
vbabanin merged 8 commits intomongodb:mainfrom Mar 20, 2026
Merged
Add Javadoc to specify that CSOT does not limit socket writes#1791vbabanin merged 8 commits intomongodb:mainfrom
vbabanin merged 8 commits intomongodb:mainfrom
Conversation
…hronous API. JAVA-5569
vbabanin
changed the title
# Conflicts: # driver-core/src/test/resources/specifications
JAVA-5569
stIncMale
requested changes
Feb 5, 2026
# Conflicts: # driver-core/src/test/resources/specifications
- Fix note format from <strong>NOTE:</strong> to <p>Note: across driver-core, driver-sync, and driver-legacy to match codebase conventions - Use plain Note: (no HTML) in driver-kotlin-sync KDoc to match Kotlin package conventions - Keep Note that format in MongoClientOptions to match existing convention within that class - Add socket-writes caveat note to all getTimeout/getDefaultTimeout getter methods - Fix @SInCE 4.x to @SInCE 5.2 in GridFSBucket.getTimeout and GridFSBucket.withTimeout JAVA-5569
vbabanin
commented
Mar 15, 2026
| * @param timeUnit the time unit | ||
| * @return the timeout in the given time unit | ||
| * @since 4.x | ||
| * @since 5.2 |
Member
Author
There was a problem hiding this comment.
I changed @since 4.x to @since 5.2 on GridFSBucket.getTimeout and GridFSBucket.withTimeout. These methods were introduced in 5.2 as part of CSOT (commit 01aff5a078), and the @since tag wasn’t updated accordingly.
stIncMale
requested changes
Mar 17, 2026
Member
|
Note also that the Evergreen build failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JAVA-5569