fix(oidc-http-server-pages): bump compass-components version COMPASS-10980 - #855
fix(oidc-http-server-pages): bump compass-components version COMPASS-10980#855esvm wants to merge 5 commits into
Conversation
esvm
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the @mongodb-js/oidc-http-server-pages workspace package to use a newer @mongodb-js/compass-components version so the generated OIDC login/callback pages render correctly (per the PR description).
Changes:
- Bump
@mongodb-js/compass-componentsdevDependency from^1.6.0to^1.68.0inpackages/oidc-http-server-pages.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "eslint": "^7.25.0 || ^8.0.0", | ||
| "gen-esm-wrapper": "^1.1.3", | ||
| "mocha": "^8.4.0", | ||
| "mongodb-query-parser": "^4.7.16", |
There was a problem hiding this comment.
alright without this the tests failed in the bootstrap due to this dependency being missed. Now that I added the depcheck says this is unused lol
There was a problem hiding this comment.
you can update the depcheck config to ignore, but there's something odd there, looks like the script that needs it is in mongodb-ts-autocomplete, does that package depend on mongodb-query-parser? maybe it was accidentally getting it transiently. Adding it as an explicit dep of mongodb-ts-autocomplete seems like the way to solve it if that's true 🤔
There was a problem hiding this comment.
only reference in the code I could find was in the shell-bson-parser. And funnily enough that package doesn't say it depends on mongodb-query-parser, but it also doesn't depend on the oidc-http or compass-components 🤔
There was a problem hiding this comment.
and running bootstrap locally works just fine 🫠
nbbeeken
changed the title
Description
https://jira.mongodb.org/browse/COMPASS-10980
Bump the version of the
@mongodb-js/compass-componentslib as this was referencing a very old instance which was causing the callback from the login page to not render properly.This issue was introduced when
leafgreen-ui/emotionwas bumped on this change.Before
After
I have tested this by manually installing a local version of this lib into compass by running:
cd packages/oidc-http-server-pages && npm packnpm install /path/to/devtools-shared/packages/oidc-http-server-pages/mongodb-js-oidc-http-server-pages-*.tgzChecklist