refactor(tracking-plan): identifyTraits must have payload#805
Open
alenakhineika wants to merge 2 commits into
Open
refactor(tracking-plan): identifyTraits must have payload#805alenakhineika wants to merge 2 commits into
alenakhineika wants to merge 2 commits into
Conversation
alenakhineika
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
IdentifyTraitsinterface is a Segment-specific concept. As part of a mongosh telemetry work, we are moving away from Segment, identify calls are now expressed as regular TelemetryEvent members with a payload field, consistent with all other events. Compass can adopt the same pattern by wrapping its existing IdentifyTraits properties inside a payload field, keeping the shared module working for both tools without any special-casing.Checklist