Skip to content

fix: pass offerings to slotUsedWeight in semester-row so FY units aren't double-counted" #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coldfinity wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: pass offerings to slotUsedWeight in semester-row so FY units aren't double-counted" #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/webapp/components/planner/semester-row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ export function SemesterRow({
slot: PlannerSlot
yearLabel: string
}) {
const { dispatch, units } = usePlanner()
const { dispatch, units, offerings } = usePlanner()
const capacity = slotCapacity(slot)
const usedWeight = slotUsedWeight(slot, units)
const usedWeight = slotUsedWeight(slot, units, offerings)
const canDecrease = capacity > Math.max(1, usedWeight)
const canIncrease = capacity < MAX_SLOT_CAPACITY
const hasUnits = slot.unitCodes.length > 0
Expand Down