Hard skip irrelevant eip tests on Monad forks#24
Conversation
Mark listed eip subdirs and ported_static with not_valid_for via per-subdir conftest hooks; trim now-redundant -k filter entries. Co-Authored-By: Claude <claude-opus-4-7>
Greptile SummaryThis PR refactors how Monad-fork-irrelevant EIP tests are excluded from the
Confidence Score: 5/5Safe to merge after #23 lands — the change is a clean mechanical refactoring with no logic alterations. Every EIP that was previously excluded via the No files require special attention. The
|
| Filename | Overview |
|---|---|
| .github/configs/feature.yaml | Core CI change: replaces the brittle multi-EIP -k exclusion string with just -k "not invalid_header", relying on conftest markers for all other exclusions. |
| tests/cancun/eip4844_blobs/conftest.py | Adds pytest_generate_tests to mark all EIP-4844 tests as not valid for Monad forks; pytest was already imported so the hook is syntactically correct. |
| tests/osaka/eip7594_peerdas/conftest.py | New conftest.py created for the EIP-7594 directory with the standard Monad-exclusion hook; explicit import pytest is present. |
| tests/paris/eip7610_create_collision/conftest.py | New conftest.py for EIP-7610; previously this directory relied solely on the -k "not eip7610" CLI filter, which is now removed. The hook provides equivalent coverage. |
| tests/ported_static/conftest.py | New conftest.py for ported-static tests; replaces the -k "not ported_static" CLI filter with the marker-based approach. |
| tests/prague/eip7685_general_purpose_el_requests/conftest.py | Adds the pytest_generate_tests hook to the existing conftest for EIP-7685; pytest already imported. |
| tests/osaka/eip7934_block_rlp_limit/conftest.py | Adds the marker hook to an existing conftest that had no per-file pytestmark; correctly picks up all current and future tests in the directory. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[fill command invoked] --> B{"--from=MONAD_EIGHT\n--until=MONAD_NINE"}
B --> C["-k 'not invalid_header'\nonly remaining CLI filter"]
C --> D[pytest collects tests]
D --> E{conftest.py in\ntest directory?}
E -->|Yes - has pytest_generate_tests| F["add_marker(\nnot_valid_for MONAD_EIGHT,\nsubsequent_forks=True\n)"]
E -->|No| G[Test collected normally]
F --> H{not_valid_for\nmechanism checks fork}
H -->|Fork is MONAD_EIGHT or later| I[Hard skip - test not generated]
H -->|Other fork| G
G --> J[Test fills to output]
Reviews (1): Last reviewed commit: "hard skip irrelevant eip tests on Monad ..." | Re-trigger Greptile
26ee93c to
be0dc67
Compare
Makes use of a mechanism introduced in #23 to tidy the
fillcommand invocation. It still leavesnot invalid_headeras that is skipped due to being problematic for monad to ingest rather than due to being irrelevant.Merge after #23