writeFile, do not force append mode#78
Open
ronaldex wants to merge 1 commit intomodxcms:2.xfrom
ronaldex:patch-1
Open
writeFile, do not force append mode#78ronaldex wants to merge 1 commit intomodxcms:2.xfrom ronaldex:patch-1
ronaldex wants to merge 1 commit intomodxcms:2.xfrom
ronaldex:patch-1
Conversation
use the actual $mode parameter instead of forcing append mode
|
Tested this and this works, and as far as I can see does not break any other thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use the actual $mode parameter instead of forcing append mode.
This behaviour caused problems on our load balancing server configuration (2 servers accessing the same modx cache directory using NFS). It lead to corrupt cache; despite the pointer is being set to the start of the file, the cache file would contain appended content.