docs(website-new): align Vite MF config with Rspack pattern#4752
Open
tonoizer wants to merge 3 commits into
Open
docs(website-new): align Vite MF config with Rspack pattern#4752tonoizer wants to merge 3 commits into
tonoizer wants to merge 3 commits into
Conversation
Align Vite integration docs with the Rspack pattern by moving federation options into module-federation.config.ts with createModuleFederationConfig. Co-authored-by: Cursor <cursoragent@cursor.com>
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
|
need to resolve conflict |
Keep the PR's component-based Vite docs (create-config + register-plugin) instead of the inline federation() snippet from main. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align Vite integration docs with the Rspack pattern by moving federation options into
module-federation.config.tswithcreateModuleFederationConfig.Description
Updates the official Vite integration docs (EN + ZH) to match how Rspack is documented:
module-federation.config.tsstep that usescreateModuleFederationConfigfrom@module-federation/vitefederation({ ... })options into that file (samename,manifest,remotes,exposes, andsharedvalues as before)vite.config.jsviafederation(mfConfig)while keeping the rest of the Vite config unchanged (server,base,build.target, comments)Shared snippets were added under
apps/website-new/src/components/common/vite/(create-config.mdx,register-plugin.mdx), consistent with the Rspack doc components.Also fixes the ZH example where
remoteswas incorrectly placed at the root ofmodule.exportsinstead of inside the federation config.Related Issue
N/A — documentation alignment only.
Types of changes
Checklist
Validation
lint-fix,commitlint)./integrations/build-tool/viteafter merge if desired.