feat(plot_bc): add subset argument#2694
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2694 +/- ##
===========================================
+ Coverage 55.5% 72.3% +16.8%
===========================================
Files 644 667 +23
Lines 124135 130334 +6199
===========================================
+ Hits 68947 94326 +25379
+ Misses 55188 36008 -19180
🚀 New features to boost your workflow:
|
flopy/plot/map.py
Outdated
| boundname : string | ||
| select boundary conditions with specific boundname | ||
| subset : int, tuple of ints, or list of such | ||
| Acceptable values depend on grid type: |
There was a problem hiding this comment.
suggest saying explicitly that this is a subset of cell IDs
There was a problem hiding this comment.
Let me know if the change is acceptable.
flopy/plot/crosssection.py
Outdated
| layer or the head value. Used to create | ||
| patches that conform to water-level elevations. | ||
| subset : int, tuple of ints, or list of such | ||
| Acceptable values depend on grid type: |
There was a problem hiding this comment.
suggest saying explicitly that this is a subset of cell IDs
There was a problem hiding this comment.
Let me know if the change is acceptable.
| ) | ||
| ax = mapview.ax | ||
|
|
||
| if len(ax.collections) == 0: |
There was a problem hiding this comment.
this could assert that with subset the number of geometries added to the plot is different than without but if this test is just for visual checking there is no need I guess.
There was a problem hiding this comment.
Add check of specific number of non-masked values
2 participants
Add subset argument to map and cross-section plots that allows a selection of boundary conditions to be shown.