feat(mfusgwel): add boundnames support for well package#2693
Closed
reneangermeyer wants to merge 1 commit intomodflowpy:developfrom
Closed
feat(mfusgwel): add boundnames support for well package#2693reneangermeyer wants to merge 1 commit intomodflowpy:developfrom
reneangermeyer wants to merge 1 commit intomodflowpy:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2693 +/- ##
===========================================
+ Coverage 55.5% 72.3% +16.8%
===========================================
Files 644 667 +23
Lines 124135 130546 +6411
===========================================
+ Hits 68947 94464 +25517
+ Misses 55188 36082 -19106
🚀 New features to boost your workflow:
|
ee0b2a0 to
a5290e5
Compare
Captures undeclared trailing text in MODFLOW-USG WEL files (common in Groundwater Vistas exports) as comment columns with object dtype. Comments are preserved on read/write roundtrip without being declared as AUX in the header. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
a5290e5 to
1d15b33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for reading and writing well names (boundnames) in the MODFLOW-USG WEL package. Since MODFLOW-USG doesn't natively support the BOUNDNAMES keyword, boundnames are implemented as auxiliary variables.
Changes:
boundnamesparameter to MfUsgWel.init for creating wells with boundnamesstring_aux_namesparameter to MfUsgWel.get_empty() for loading files with string-type auxiliary variablesThe implementation supports:
boundnames=Trueaux boundnamedeclarations