feat(get_transmissivities): interpret head=None as fully saturated#2690
Merged
wpbonelli merged 2 commits intomodflowpy:developfrom Jan 29, 2026
Merged
feat(get_transmissivities): interpret head=None as fully saturated#2690wpbonelli merged 2 commits intomodflowpy:developfrom
wpbonelli merged 2 commits intomodflowpy:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2690 +/- ##
===========================================
+ Coverage 55.5% 72.3% +16.8%
===========================================
Files 644 667 +23
Lines 124135 130394 +6259
===========================================
+ Hits 68947 94377 +25430
+ Misses 55188 36017 -19171
🚀 New features to boost your workflow:
|
wpbonelli
commented
Jan 28, 2026
flopy/utils/postprocessing.py
Outdated
| heads, | ||
| m, | ||
| heads=None, | ||
| m=None, |
Member
Author
There was a problem hiding this comment.
the model should not default to None, it is required
Member
Author
There was a problem hiding this comment.
heads should also not default to None, just interpret an explicitly passed None as fully saturated
jdhughes-dev
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2610