Skip to content

fix: update puppeteer to v25#3135

Open
bashmish wants to merge 3 commits into
masterfrom
fix/update-puppeteer-to-v25
Open

fix: update puppeteer to v25#3135
bashmish wants to merge 3 commits into
masterfrom
fix/update-puppeteer-to-v25

Conversation

@bashmish

@bashmish bashmish commented Jul 16, 2026

Copy link
Copy Markdown
Member

What I did

  1. Update puppeteer to v25 in @web/test-runner-chrome and @web/test-runner-puppeteer
  2. puppeteer v25 required Node 22+, so no major update from the perspective of our new engine requirements, we are aligned on this
  3. Replaced removed isConnected() with a new property connected
  4. Test which redirects to a new origin became super flaky, I investigated and turned out it's due to a BFCache and browser not closing the WebSocket connection when navigating to a new page, most likely because new puppeteer installed newer Chrome where BFCache is more aggressive, but it's hard to say exactly why it happens. I fixed this by using unload even listener which practically disabled BFCache

@changeset-bot

changeset-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 64d2d0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@web/dev-server-core Patch
@web/test-runner-puppeteer Patch
@web/test-runner-chrome Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bashmish
bashmish force-pushed the fix/update-puppeteer-to-v25 branch 8 times, most recently from c297995 to 6190a7d Compare July 22, 2026 14:41
@bashmish
bashmish force-pushed the fix/update-puppeteer-to-v25 branch from 6190a7d to a9d0f29 Compare July 22, 2026 15:08
@bashmish
bashmish force-pushed the fix/update-puppeteer-to-v25 branch from a9d0f29 to 64d2d0c Compare July 22, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant