refactor: use import type for type-only imports

.github/workflows/verify-node.yml

@@ -56,6 +56,8 @@ jobs:
 
       - name: Test
         run: npm run test:node
+        env:
+          NODE_OPTIONS: ${{ (matrix.node-version != '18' && matrix.node-version != '20') && '--no-experimental-strip-types' || '' }}
 
   verify-windows:
     timeout-minutes: 30

packages/dev-server-core/src/plugins/Plugin.ts

@@ -1,9 +1,9 @@
 import { FSWatcher } from 'chokidar';
 import Koa, { Context } from 'koa';
-import { Server } from 'net';
+import { type Server } from 'net';
 
-import { DevServerCoreConfig } from '../server/DevServerCoreConfig';
-import { Logger } from '../logger/Logger';
+import type { DevServerCoreConfig } from '../server/DevServerCoreConfig';
+import type { Logger } from '../logger/Logger';
 import { WebSocketsManager } from '../web-sockets/WebSocketsManager';
 
 export type ServeResult =

packages/dev-server-core/src/server/createServer.ts

@@ -6,9 +6,9 @@ import http2Server from 'http2';
 import fs from 'fs';
 import net, { Server, Socket, ListenOptions } from 'net';
 
-import { DevServerCoreConfig } from './DevServerCoreConfig.js';
+import type { DevServerCoreConfig } from './DevServerCoreConfig.js';
 import { createMiddleware } from './createMiddleware.js';
-import { Logger } from '../logger/Logger.js';
+import type { Logger } from '../logger/Logger.js';
 import { addPlugins } from './addPlugins.js';
 
 /**

packages/dev-server-rollup/src/index.ts

@@ -1,4 +1,4 @@
-export { RollupNodeResolveOptions, nodeResolve } from '@rollup/plugin-node-resolve';
+export { type RollupNodeResolveOptions, nodeResolve } from '@rollup/plugin-node-resolve';
 export { fromRollup } from './fromRollup.js';
 export { rollupAdapter } from './rollupAdapter.js';
 export { rollupBundlePlugin } from './rollupBundlePlugin.js';

packages/dev-server/src/config/DevServerConfig.ts

@@ -1,5 +1,5 @@
-import { DevServerCoreConfig } from '@web/dev-server-core';
-import { RollupNodeResolveOptions } from '@web/dev-server-rollup';
+import { type DevServerCoreConfig } from '@web/dev-server-core';
+import { type RollupNodeResolveOptions } from '@web/dev-server-rollup';
 
 export interface DevServerConfig extends DevServerCoreConfig {
   /**

packages/dev-server/src/config/mergeConfigs.ts

@@ -1,4 +1,4 @@
-import { DevServerConfig } from './DevServerConfig.js';
+import { type DevServerConfig } from './DevServerConfig.js';
 
 const arrayKeys = ['plugins', 'middleware'];
 

packages/dev-server/src/config/parseConfig.ts

@@ -1,9 +1,9 @@
 import { getPortPromise } from 'portfinder';
 import path from 'path';
 
-import { DevServerCliArgs } from './readCliArgs.js';
+import { type DevServerCliArgs } from './readCliArgs.js';
 import { mergeConfigs } from './mergeConfigs.js';
-import { DevServerConfig } from './DevServerConfig.js';
+import { type DevServerConfig } from './DevServerConfig.js';
 import { esbuildPlugin } from '../plugins/esbuildPlugin.js';
 import { watchPlugin } from '../plugins/watchPlugin.js';
 import { nodeResolvePlugin } from '../plugins/nodeResolvePlugin.js';

packages/dev-server/src/config/readCliArgs.ts

@@ -1,7 +1,7 @@
 import commandLineArgs from 'command-line-args';
 import commandLineUsage, { OptionDefinition } from 'command-line-usage';
 import camelCase from 'camelcase';
-import { DevServerConfig } from './DevServerConfig.js';
+import { type DevServerConfig } from './DevServerConfig.js';
 
 export interface DevServerCliArgs
   extends Partial<

packages/dev-server/src/logger/DevServerLogger.ts

@@ -1,4 +1,4 @@
-import { Logger, PluginSyntaxError } from '@web/dev-server-core';
+import { type Logger, PluginSyntaxError } from '@web/dev-server-core';
 import { codeFrameColumns } from '@babel/code-frame';
 import path from 'path';
 import { red, cyan } from 'nanocolors';

packages/dev-server/src/logger/createLogger.ts

@@ -1,4 +1,4 @@
-import { Plugin } from '@web/dev-server-core';
+import { type Plugin } from '@web/dev-server-core';
 import { DevServerLogger } from './DevServerLogger.js';
 import { logStartMessage } from './logStartMessage.js';
 

packages/dev-server/src/logger/logStartMessage.ts

@@ -1,5 +1,5 @@
-import { DevServerConfig } from '../config/DevServerConfig';
-import { Logger } from '@web/dev-server-core';
+import { type DevServerConfig } from '../config/DevServerConfig';
+import { type Logger } from '@web/dev-server-core';
 import internalIp from 'internal-ip';
 import { bold, cyan, white } from 'nanocolors';
 

packages/dev-server/src/plugins/nodeResolvePlugin.ts

@@ -1,5 +1,5 @@
-import { nodeResolve, rollupAdapter, RollupNodeResolveOptions } from '@web/dev-server-rollup';
-import { Plugin } from '@web/dev-server-core';
+import { nodeResolve, rollupAdapter, type RollupNodeResolveOptions } from '@web/dev-server-rollup';
+import { type Plugin } from '@web/dev-server-core';
 import deepmerge from 'deepmerge';
 
 export function nodeResolvePlugin(

packages/dev-server/src/plugins/watchPlugin.ts

@@ -1,4 +1,4 @@
-import { Plugin } from '@web/dev-server-core';
+import { type Plugin } from '@web/dev-server-core';
 import debounce from 'debounce';
 
 export function watchPlugin(): Plugin {

packages/rollup-plugin-html/src/assets/utils.ts

@@ -1,4 +1,4 @@
-import { Document, Element } from 'parse5';
+import type { Document, Element } from 'parse5';
 import path from 'path';
 import picomatch from 'picomatch';
 import { findElements, getTagName, getAttribute } from '@web/parse5-utils';

packages/rollup-plugin-html/src/index.ts

@@ -1,6 +1,6 @@
-import { rollupPluginHTML, RollupPluginHtml } from './rollupPluginHTML.js';
+import { rollupPluginHTML, type RollupPluginHtml } from './rollupPluginHTML.js';
 
-export {
+export type {
   InputHTMLOptions,
   RollupPluginHTMLOptions,
   GeneratedBundle,
@@ -10,5 +10,5 @@ export {
   TransformAssetFunction,
 } from './RollupPluginHTMLOptions.js';
 
-export { rollupPluginHTML, RollupPluginHtml };
+export { rollupPluginHTML, type RollupPluginHtml };
 export default rollupPluginHTML;

packages/rollup-plugin-html/src/input/extract/extractAssets.ts

@@ -1,7 +1,7 @@
-import { Document, serialize } from 'parse5';
+import { type Document, serialize } from 'parse5';
 import fs from 'fs';
 import path from 'path';
-import { InputAsset } from '../InputData.js';
+import { type InputAsset } from '../InputData.js';
 import {
   findAssets,
   getSourcePaths,

packages/rollup-plugin-html/src/input/extract/extractModules.ts

@@ -1,10 +1,10 @@
 import { findElements, getAttribute, getTagName, getTextContent, remove } from '@web/parse5-utils';
-import { Document, Attribute } from 'parse5';
+import { type Document, type Attribute } from 'parse5';
 import path from 'path';
 import crypto from 'crypto';
 import { resolveAssetFilePath } from '../../assets/utils.js';
 import { getAttributes } from '@web/parse5-utils';
-import { ScriptModuleTag } from '../../RollupPluginHTMLOptions.js';
+import { type ScriptModuleTag } from '../../RollupPluginHTMLOptions.js';
 
 export interface ExtractModulesParams {
   document: Document;

packages/rollup-plugin-html/src/output/hashInlineScripts.ts

@@ -1,4 +1,4 @@
-import { Document, Element, ParentNode } from 'parse5';
+import type { Document, Element, ParentNode } from 'parse5';
 import {
   findElement,
   findElements,

packages/rollup-plugin-html/src/output/injectAbsoluteBaseUrl.ts

@@ -1,4 +1,4 @@
-import { Document, Element } from 'parse5';
+import type { Document, Element } from 'parse5';
 import { findElements, getTagName, getAttribute, setAttribute } from '@web/parse5-utils';
 
 function isAbsoluteableNode(node: Element) {

packages/rollup-plugin-html/src/output/injectBundles.ts

@@ -1,7 +1,7 @@
-import { Document, Attribute } from 'parse5';
+import type { Document, Attribute } from 'parse5';
 import { createScript, findElement, getTagName, appendChild } from '@web/parse5-utils';
 
-import { EntrypointBundle } from '../RollupPluginHTMLOptions.js';
+import { type EntrypointBundle } from '../RollupPluginHTMLOptions.js';
 import { createError } from '../utils.js';
 
 export function createLoadScript(src: string, format: string, attributes?: Attribute[]) {

packages/rollup-plugin-html/src/output/injectServiceWorkerRegistration.ts

@@ -1,5 +1,5 @@
 import path from 'path';
-import { Document } from 'parse5';
+import type { Document } from 'parse5';
 import {
   findElement,
   getTagName,

packages/rollup-plugin-html/src/output/injectedUpdatedAssetPaths.ts

@@ -1,5 +1,5 @@
 import { getAttribute, setAttribute } from '@web/parse5-utils';
-import { Document } from 'parse5';
+import type { Document } from 'parse5';
 import path from 'path';
 
 import {
@@ -10,9 +10,9 @@ import {
   resolveAssetFilePath,
   createAssetPicomatchMatcher,
 } from '../assets/utils.js';
-import { InputData } from '../input/InputData.js';
+import { type InputData } from '../input/InputData.js';
 import { createError } from '../utils.js';
-import { EmittedAssets } from './emitAssets.js';
+import { type EmittedAssets } from './emitAssets.js';
 import { toBrowserPath } from './utils.js';
 
 export interface InjectUpdatedAssetPathsArgs {

packages/rollup-plugin-polyfills-loader/src/types.d.ts

@@ -1,4 +1,4 @@
-import { PolyfillsConfig, FileType } from '@web/polyfills-loader';
+import { PolyfillsConfig, type FileType } from '@web/polyfills-loader';
 
 export interface OutputConfig {
   name: string;

packages/test-runner-commands/test/execute-server-command/executeServerCommand.test.ts

@@ -1,7 +1,7 @@
 import path from 'path';
 import { runTests } from '@web/test-runner-core/test-helpers';
 import { chromeLauncher } from '@web/test-runner-chrome';
-import { Logger } from '@web/dev-server-core';
+import type { Logger } from '@web/dev-server-core';
 
 describe('executeServerCommand', function test() {
   this.timeout(20000);

packages/test-runner-core/src/browser-launcher/BrowserLauncher.ts

@@ -1,6 +1,6 @@
-import { CoverageMapData } from 'istanbul-lib-coverage';
-import { TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig';
-import { TestResultError } from '../test-session/TestSession';
+import type { CoverageMapData } from 'istanbul-lib-coverage';
+import { type TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig';
+import { type TestResultError } from '../test-session/TestSession';
 
 export interface SessionResult {
   testCoverage?: CoverageMapData;

packages/test-runner-core/src/cli/BufferedLogger.ts

@@ -1,4 +1,4 @@
-import { Logger, ErrorWithLocation } from '../logger/Logger';
+import { type Logger, type ErrorWithLocation } from '../logger/Logger';
 
 export class BufferedLogger implements Logger {
   public buffer: { method: keyof Logger; args?: any[] }[] = [];

packages/test-runner-core/src/cli/TestRunnerCli.ts

@@ -10,12 +10,12 @@ import { DynamicTerminal } from './terminal/DynamicTerminal.js';
 import { BufferedLogger } from './BufferedLogger.js';
 import { getManualDebugMenu } from './getManualDebugMenu.js';
 import { ErrorWithLocation } from '../logger/Logger.js';
-import { TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig.js';
-import { TestSessionManager } from '../test-session/TestSessionManager.js';
+import { type TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig.js';
+import { type TestSessionManager } from '../test-session/TestSessionManager.js';
 import { SESSION_STATUS } from '../test-session/TestSessionStatus.js';
-import { Logger } from '../logger/Logger.js';
+import { type Logger } from '../logger/Logger.js';
 import { TestRunner } from '../runner/TestRunner.js';
-import { TestCoverage } from '../coverage/getTestCoverage.js';
+import { type TestCoverage } from '../coverage/getTestCoverage.js';
 
 export type MenuType = 'none' | 'overview' | 'focus' | 'debug' | 'manual-debug';
 

packages/test-runner-core/src/cli/getManualDebugMenu.ts

@@ -1,7 +1,7 @@
 import { cyan, gray } from 'nanocolors';
 import internalIp from 'internal-ip';
 
-import { TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig';
+import { type TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig';
 
 export function getManualDebugMenu(config: TestRunnerCoreConfig): string[] {
   const localAddress = `${config.protocol}//${config.hostname}:${config.port}/`;

packages/test-runner-core/src/cli/writeCoverageReport.ts

@@ -1,8 +1,8 @@
 import reports from 'istanbul-reports';
 import libReport from 'istanbul-lib-report';
 
-import { CoverageConfig } from '../config/TestRunnerCoreConfig';
-import { TestCoverage } from '../coverage/getTestCoverage';
+import { type CoverageConfig } from '../config/TestRunnerCoreConfig';
+import { type TestCoverage } from '../coverage/getTestCoverage';
 
 export function writeCoverageReport(testCoverage: TestCoverage, config: CoverageConfig) {
   // create a context for report generation

packages/test-runner-core/src/config/TestRunnerCoreConfig.ts

@@ -1,11 +1,11 @@
-import { Middleware } from '@web/dev-server-core';
-import { BrowserLauncher } from '../browser-launcher/BrowserLauncher.js';
-import { TestFramework } from '../test-framework/TestFramework.js';
-import { TestSession } from '../test-session/TestSession.js';
-import { Reporter } from '../reporter/Reporter.js';
-import { Logger } from '../logger/Logger.js';
-import { TestRunnerPlugin } from '../server/TestRunnerPlugin.js';
-import { ReportType } from 'istanbul-reports';
+import { type Middleware } from '@web/dev-server-core';
+import { type BrowserLauncher } from '../browser-launcher/BrowserLauncher.js';
+import { type TestFramework } from '../test-framework/TestFramework.js';
+import { type TestSession } from '../test-session/TestSession.js';
+import { type Reporter } from '../reporter/Reporter.js';
+import { type Logger } from '../logger/Logger.js';
+import { type TestRunnerPlugin } from '../server/TestRunnerPlugin.js';
+import type { ReportType } from 'istanbul-reports';
 
 export interface CoverageThresholdConfig {
   statements: number;

packages/test-runner-core/src/config/TestRunnerGroupConfig.ts

@@ -1,5 +1,5 @@
-import { BrowserLauncher } from '../browser-launcher/BrowserLauncher';
-import { TestRunnerCoreConfig } from './TestRunnerCoreConfig.js';
+import { type BrowserLauncher } from '../browser-launcher/BrowserLauncher';
+import { type TestRunnerCoreConfig } from './TestRunnerCoreConfig.js';
 
 export interface TestRunnerGroupConfig {
   name: string;

packages/test-runner-core/src/coverage/getTestCoverage.ts

@@ -1,15 +1,15 @@
 import {
   createCoverageMap,
-  CoverageSummaryData,
-  CoverageMap,
-  CoverageMapData,
-  BranchMapping,
-  FunctionMapping,
-  Location,
-  Range,
+  type CoverageSummaryData,
+  type CoverageMap,
+  type CoverageMapData,
+  type BranchMapping,
+  type FunctionMapping,
+  type Location,
+  type Range,
 } from 'istanbul-lib-coverage';
-import { TestSession } from '../test-session/TestSession';
-import { CoverageConfig } from '../config/TestRunnerCoreConfig';
+import { type TestSession } from '../test-session/TestSession';
+import { type CoverageConfig } from '../config/TestRunnerCoreConfig';
 
 export const coverageTypes: (keyof CoverageSummaryData)[] = [
   'lines',

packages/test-runner-core/src/reporter/Reporter.ts

@@ -1,9 +1,9 @@
-import { TestSession } from '../test-session/TestSession';
-import { TestSessionManager } from '../test-session/TestSessionManager';
-import { TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig';
-import { TestCoverage } from '../coverage/getTestCoverage';
-import { Logger } from '../logger/Logger';
-import { BrowserLauncher } from '../browser-launcher/BrowserLauncher';
+import { type TestSession } from '../test-session/TestSession';
+import { type TestSessionManager } from '../test-session/TestSessionManager';
+import { type TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig';
+import { type TestCoverage } from '../coverage/getTestCoverage';
+import { type Logger } from '../logger/Logger';
+import { type BrowserLauncher } from '../browser-launcher/BrowserLauncher';
 
 export interface ReporterArgs {
   config: TestRunnerCoreConfig;

packages/test-runner-core/src/runner/TestRunner.ts

@@ -1,16 +1,16 @@
-import { TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig.js';
+import { type TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig.js';
 import { createTestSessions } from './createSessionGroups.js';
-import { TestSession } from '../test-session/TestSession.js';
-import { getTestCoverage, TestCoverage } from '../coverage/getTestCoverage.js';
+import { type TestSession } from '../test-session/TestSession.js';
+import { getTestCoverage, type TestCoverage } from '../coverage/getTestCoverage.js';
 import { TestScheduler } from './TestScheduler.js';
 import { TestSessionManager } from '../test-session/TestSessionManager.js';
 import { SESSION_STATUS } from '../test-session/TestSessionStatus.js';
 import { EventEmitter } from '../utils/EventEmitter.js';
 import { createSessionUrl } from './createSessionUrl.js';
 import { createDebugSessions } from './createDebugSessions.js';
 import { TestRunnerServer } from '../server/TestRunnerServer.js';
-import { BrowserLauncher } from '../browser-launcher/BrowserLauncher.js';
-import { TestRunnerGroupConfig } from '../config/TestRunnerGroupConfig.js';
+import { type BrowserLauncher } from '../browser-launcher/BrowserLauncher.js';
+import { type TestRunnerGroupConfig } from '../config/TestRunnerGroupConfig.js';
 
 interface EventMap {
   'test-run-started': { testRun: number };

packages/test-runner-core/src/runner/TestScheduler.ts

@@ -1,11 +1,11 @@
 import { createSessionUrl } from './createSessionUrl.js';
-import { TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig.js';
-import { TestSessionManager } from '../test-session/TestSessionManager.js';
-import { TestSession, TestResultError } from '../test-session/TestSession.js';
+import { type TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig.js';
+import { type TestSessionManager } from '../test-session/TestSessionManager.js';
+import { type TestSession, type TestResultError } from '../test-session/TestSession.js';
 import { SESSION_STATUS } from '../test-session/TestSessionStatus.js';
 import { withTimeout } from '../utils/async.js';
 import { TestSessionTimeoutHandler } from './TestSessionTimeoutHandler.js';
-import { BrowserLauncher } from '../browser-launcher/BrowserLauncher.js';
+import { type BrowserLauncher } from '../browser-launcher/BrowserLauncher.js';
 
 export class TestScheduler {
   private config: TestRunnerCoreConfig;

packages/test-runner-core/src/runner/TestSessionTimeoutHandler.ts

@@ -1,6 +1,6 @@
-import { TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig.js';
-import { TestSessionManager } from '../test-session/TestSessionManager.js';
-import { TestSession, TestResultError } from '../test-session/TestSession.js';
+import { type TestRunnerCoreConfig } from '../config/TestRunnerCoreConfig.js';
+import { type TestSessionManager } from '../test-session/TestSessionManager.js';
+import { type TestSession, type TestResultError } from '../test-session/TestSession.js';
 import { SESSION_STATUS } from '../test-session/TestSessionStatus.js';
 import { TestScheduler } from './TestScheduler.js';
 

packages/test-runner-core/src/runner/createDebugSessions.ts

@@ -1,6 +1,6 @@
 import { nanoid } from 'nanoid';
-import { DebugTestSession } from '../test-session/DebugTestSession';
-import { TestSession } from '../test-session/TestSession';
+import { type DebugTestSession } from '../test-session/DebugTestSession';
+import { type TestSession } from '../test-session/TestSession';
 
 export function createDebugSessions(sessions: TestSession[]): DebugTestSession[] {
   const debugSessions = [];