Fix issue where PictureBox image from a URL was getting truncated.#115
Merged
Fix issue where PictureBox image from a URL was getting truncated.#115
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where PictureBox images loaded from a URL could render truncated, and aligns some error-state rendering with DPI/padding behavior in the UI rendering layer.
Changes:
- Load remote images by downloading the full response payload (
GetByteArrayAsync) before decoding viaSKBitmap.Decode. - Update the error “X” glyph rendering in
PictureBoxRendererto use padded client sizing and DPI-scaled stroke width.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Modern.Forms/PictureBox.cs |
Switches URL image loading to byte-array download before decoding to avoid truncation issues from streaming. |
src/Modern.Forms/Renderers/PictureBoxRenderer.cs |
Updates error glyph rendering to use PaddedClientRectangle dimensions and DPI-scaled thickness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where
PictureBoximages loaded from a URL could render truncated, and aligns some error-state rendering with DPI/padding behavior in the UI rendering layer.Changes:
GetByteArrayAsync) before decoding viaSKBitmap.Decode.PictureBoxRendererto use padded client sizing and DPI-scaled stroke width.