Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Modern.Forms.Timer component intended for UI scenarios, implemented on top of Modern.WindowKit.Threading.DispatcherTimer to raise Tick on the UI thread.
Changes:
- Added a
Timercomponent withTickevent andStart()/Stop()control. - Added
EnabledandIntervalproperties (with interval validation) and disposal logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jpobst
reviewed
Apr 1, 2026
Collaborator
jpobst
left a comment
jpobst
left a comment
There was a problem hiding this comment.
I think the Copilot comment about resetting enabled in Dispose is a good idea. The rest of its suggestions are safe to ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Timer component to Modern.Forms.
The implementation is based on DispatcherTimer and ensures that the Tick
Supports Start / Stop
Configurable Interval