Fix ContextMenu border clipping on fractional DPI displays#111
Draft
Fix ContextMenu border clipping on fractional DPI displays#111
Conversation
Agent-Logs-Url: https://github.com/modern-forms/Modern.Forms/sessions/d0c46711-dd38-48bb-882b-ca5e8f824e59 Co-authored-by: jpobst <179295+jpobst@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix wrong border for ContextMenu on fractional resolution displays
Fix ContextMenu border clipping on fractional DPI displays
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At fractional display scaling (e.g. 150%), the device→logical pixel conversion in
MenuDropDown.ScaleSizeusesMath.Round, which can round down. The resulting popup window is 1 device pixel too small, clipping the right and bottom border edges.Math.Ceilinginstead ofMath.RoundinScaleSizeto ensure the logical size always covers the full device pixel contentNo effect at integer scaling factors (100%, 200%) where the division is exact.
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.