refactor(ui): isolate extension workspace controls - #862
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR extracts extension workspace read/write orchestration from
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, lifecycle, or security regression identified. The extraction preserves the prior callback dependencies and live-input semantics, while focused tests cover authority retirement, target verification, write outcomes, and review reconciliation. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
Command[Extension command] --> Context[App command context]
Context --> Controller[Workspace controls controller]
Controller --> Lease[Validate capability lease]
Lease --> Target[Resolve reviewed file target]
Target --> Verify1[Verify filesystem target]
Verify1 --> Consent[Attributed confirmation]
Consent --> Verify2[Reverify filesystem target]
Verify2 --> Runner[Host write runner]
Runner --> Write[Write reviewed file]
Write --> Refresh[Reconcile mounted review]
Reviews (1): Last reviewed commit: "refactor(ui): isolate extension workspac..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bun test src/ui/hooks/useExtensionWorkspaceControls.test.tsx src/ui/App.extension-command-controls.test.tsx src/ui/AppHost.workspace.test.tsxbun run typecheckbun run deps:checkbun run lintbun run format:checkThis PR description was generated by Pi using GPT-5.6 Sol