refactor(ui): simplify copy-selection row ranges - #859
Open
benvinegar wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis behavior-preserving refactor replaces overlapping row-interval branches with equivalent start/end boundary algebra.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or quality issues identified. The simplified comparisons preserve the old branch behavior for all intersecting interval relationships, including equality boundaries, wrapped rows, reverse drags, and pinned-header selections. Important Files Changed
Reviews (1): Last reviewed commit: "refactor(ui): simplify copy selection ra..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
buildCopySelectedRowKeysclassified every intersecting row through four overlapping interval cases. Those branches all encoded the same two boundary questions, making wrapped-row selection behavior harder to verify than necessary.Approach
This is a behavior-preserving maintenance refactor. It does not change clipboard rendering or selection interaction.
Cyclomatic complexity for
buildCopySelectedRowKeysdrops from 24 to 14.Validation
Tested on Linux:
bun test src/ui/components/panes/copySelection.test.ts— 53 passed;bun run typecheck;bun run lint;bunx oxfmt --check src/ui/components/panes/copySelection.ts src/ui/components/panes/copySelection.test.ts;git diff --check main...HEAD.An independent exhaustive probe compared the old and new formulas across 6,998 intersecting integer interval combinations with no mismatch. No visual evidence is included because rendered behavior is unchanged.
This PR description was generated by Pi using OpenAI GPT-5.6 Sol