feat(ui): add Ctrl-D and Ctrl-U scrolling aliases - #855
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR adds Ctrl-D and Ctrl-U as default aliases for half-page scrolling while retaining the existing plain d and u bindings.
Confidence Score: 5/5The PR appears safe to merge, with the new aliases aligned across runtime configuration, documentation, unit tests, and live PTY coverage. The command matcher supports both named control-key events and bare terminal control bytes, higher-priority focused inputs and modes retain ownership, and no concrete conflicting built-in binding or broken navigation path remains. Important Files Changed
Reviews (1): Last reviewed commit: "feat(ui): add Ctrl-D and Ctrl-U scrollin..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl-DandCtrl-Uas default aliases for half-page scrollingdandushortcutsCloses #838
Testing
bun run typecheckbun test src/ui/lib/appCommands.test.ts src/ui/lib/helpContent.test.tsbun test test/pty/pager.test.tsbun run lintbun run check:docsThis PR description was generated by Pi using gpt-5.6-sol