Skip to content

feat(ui): add Ctrl-D and Ctrl-U scrolling aliases - #855

Merged
benvinegar merged 1 commit into
mainfrom
fix/ctrl-half-page-navigation
Aug 26, 2026
Merged

feat(ui): add Ctrl-D and Ctrl-U scrolling aliases#855
benvinegar merged 1 commit into
mainfrom
fix/ctrl-half-page-navigation

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • add Ctrl-D and Ctrl-U as default aliases for half-page scrolling
  • preserve the existing plain d and u shortcuts
  • cover the aliases in command and PTY tests and document the defaults

Closes #838

Testing

  • bun run typecheck
  • bun test src/ui/lib/appCommands.test.ts src/ui/lib/helpContent.test.ts
  • bun test test/pty/pager.test.ts
  • bun run lint
  • bun run check:docs
  • changed-file formatting check

This PR description was generated by Pi using gpt-5.6-sol

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hunk-web Ignored Ignored Aug 26, 2026 12:01am

Request Review

@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds Ctrl-D and Ctrl-U as default aliases for half-page scrolling while retaining the existing plain d and u bindings.

  • Updates the built-in command catalog and keybinding documentation.
  • Adds command-level coverage for both aliases and their default-key declarations.
  • Updates the PTY pager test to exercise the new control-key bindings in a live terminal flow.
  • Adds a patch changeset for the user-facing behavior.

Confidence Score: 5/5

The PR appears safe to merge, with the new aliases aligned across runtime configuration, documentation, unit tests, and live PTY coverage.

The command matcher supports both named control-key events and bare terminal control bytes, higher-priority focused inputs and modes retain ownership, and no concrete conflicting built-in binding or broken navigation path remains.

Important Files Changed

Filename Overview
src/core/run/commandCatalog.ts Adds Ctrl-D and Ctrl-U to the existing half-page navigation commands without changing their semantics or removing prior bindings.
src/ui/lib/appCommands.test.ts Verifies dispatch and catalog exposure for the new control-key aliases while preserving plain d/u coverage.
test/pty/pager.test.ts Exercises both new aliases through the PTY-backed pager navigation flow.
docs/keybindings.md Keeps the documented default-key table aligned with the runtime command catalog.

Reviews (1): Last reviewed commit: "feat(ui): add Ctrl-D and Ctrl-U scrollin..." | Re-trigger Greptile

@benvinegar
benvinegar merged commit c6ebba9 into main Aug 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] ctrl+d/ctrl+u along with d/u keys to navigate main TUI

1 participant