[Fix] Fix background heartbeat requests falling back to the default Twinkle server URL

[kevssim]

PR type

• Bug Fix
• New Feature
• Document Updates
• More Models or Datasets Support

PR information

Fix Twinkle client heartbeat using the wrong default server address in background threads.

Previously, init_twinkle_client(base_url=...) only updated thread-local context, while processor heartbeat threads could still fall back to http://127.0.0.1:8000, which caused repeated heartbeat failures and could interrupt training after retries.

This PR:

• adds a global fallback for base_url in twinkle_client.http.utils
• keeps set_base_url() and get_base_url() consistent across main-thread and background-thread access
• fixes background requests unexpectedly falling back to http://127.0.0.1:8000

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug where background heartbeat threads in the Twinkle client were failing due to incorrectly resolving the server's base URL. By introducing a global fallback mechanism for the base URL and updating the URL management functions, the change ensures that all threads consistently use the correct server address, thereby preventing repeated heartbeat failures and potential interruptions to training processes.

Highlights

• Heartbeat Server Address Fix: Corrected the Twinkle client heartbeat mechanism to use the proper server address, preventing background threads from defaulting to an incorrect local address.
• Global Base URL Fallback: Implemented a global fallback for the base_url within twinkle_client.http.utils to ensure consistent server address resolution across all threads, including background heartbeat processes.
• Consistent URL Access: Ensured that set_base_url() and get_base_url() functions now provide consistent access to the base URL for both main and background threads, resolving issues where background requests would use an outdated or incorrect server address.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/twinkle_client/http/heartbeat.py
  • Removed direct dependency on TWINKLE_SERVER_URL and self.server_url.
  • Updated heartbeat URL construction to dynamically retrieve the base URL using get_base_url().
• src/twinkle_client/http/utils.py
  • Introduced _global_base_url to provide a thread-agnostic fallback for the base URL.
  • Modified set_base_url to update both the thread-local context and the new global fallback.
  • Adjusted get_base_url to check the thread-local context, then the global fallback, and finally the environment variable.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the issue of background heartbeat threads using the wrong server address by introducing a global fallback for the base URL. The changes in heartbeat.py correctly adopt the new get_base_url utility. However, the implementation in utils.py introduces a new bug where clear_base_url() no longer works as expected, and it may not be thread-safe depending on usage patterns. I've added a comment with details on how to address this.