Skip to content

Feat/refactor 1#1

Merged
tastelikefeet merged 6 commits into
modelscope:mainfrom
tastelikefeet:feat/refactor-1
Jun 29, 2026
Merged

Feat/refactor 1#1
tastelikefeet merged 6 commits into
modelscope:mainfrom
tastelikefeet:feat/refactor-1

Conversation

@tastelikefeet

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Twinkle documentation and blog site, adding several new technical blog posts (covering Multi-LoRA, Ascend NPU, OpenEnv, Sequence Parallel, and TUI), updating the landing page with new features and supported models, and restructuring the Cookbook recipes. It also introduces scripts for link checking and syncing Sphinx documentation. The review feedback highlights several critical issues: bugs in the sync-docs.py script where comments inside code blocks are incorrectly stripped and path resolution can fail; a bug in check-links.py where absolute internal links starting with a slash resolve incorrectly; broken relative links in the getting-started documentation; and relative menu URLs in the configuration files that will cause 404 errors on subpages.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread scripts/sync-docs.py
Comment thread scripts/sync-docs.py Outdated
Comment thread scripts/check-links.py
Comment thread scripts/sync-docs.py
Comment thread content/docs/getting-started.md Outdated
Comment thread content/docs/getting-started.zh.md Outdated
Comment thread config/_default/menus.yaml
Comment thread config/_default/menus.zh.yaml
@tastelikefeet tastelikefeet merged commit df4f8ad into modelscope:main Jun 29, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants