fix(ci): keep the transformers<5.0 pin through the package install - #9862
Open
he-yufeng wants to merge 1 commit into
Open
fix(ci): keep the transformers<5.0 pin through the package install#9862he-yufeng wants to merge 1 commit into
he-yufeng wants to merge 1 commit into
Conversation
The pin line runs before pip install ., but a pip invocation keeps no constraints across runs. The package install re-resolves trl (floor transformers>=4.56.2) against framework.txt's <5.15.0 and jumps to transformers 5.14.1, after which the suite dies importing transformers.models.gemma3 (currently red on every PR, e.g. modelscope#9854). Carrying the pin into the package install keeps the resolver on the 4.x line the tests are written for; verified it selects 4.57.6 with trl 0.29.1 in the same run. Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pin line in the CUDA path runs before
pip install ., but pip keeps no constraints across invocations. The package install then re-resolves trl (floortransformers>=4.56.2) against framework.txt's<5.15.0and jumps to transformers 5.14.1, after which the suite dies importingtransformers.models.gemma3. Every PR is red on this right now (confirmed on mine and on #9854, same error in the same step).Carrying the pin into the package install keeps the resolver on the 4.x line the suite is written for. Verified with the actual resolver:
trl==0.29.1+transformers<5.0in one run selects transformers 4.57.6, which satisfies trl's floor and keeps gemma3 importable.The NPU path already carries the pin inside its own command and is untouched. Whether framework.txt itself should drop
<5.15.0for users is a bigger support-range question I left alone here.