fix(utils): preserve streamed download bytes - #9857
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Use raw response chunks for ModelScope file downloads so newline and binary bytes are not discarded. Close streamed responses reliably and validate HTTP status for both download helpers. Test: .venv/bin/python tests/run.py --pattern test_hub_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
download_ms_filestreamed responses throughiter_lines(). That API removesline delimiters, so downloaded binary or text artifacts containing newline
bytes were silently changed on disk. Both streamed download helpers also left
their HTTP responses open after completion or failure.
This PR:
iter_content()to preserve the response bytes;The change is limited to the two download helpers in
swift.utils.hub_utils.It does not change cache paths or retry behavior.
Experiment results
Before the fix:
After the fix: