Examples/InductionMachines/IMC_DCBraking.mo #4691
Examples/InductionMachines/IMC_DCBraking.mo #4691AHaumer wants to merge 4 commits intomodelica:masterfrom
Conversation
changes the comparisonSignals (old ones are bad - see discussion in modelica#4688)
|
Sorry @uschna I have to check in detail today's evening. |
|
Dear @AHaumer,
Hence, I must test it again. |
|
Thanks for looking into details, @uschna |
|
Dear @AHaumer, |
I would keep 4.1.1 for critical fixes, e.g. if we discover late that we introduced regressions in 4.1.0. |
Why not comparing the current phasor components, from which you are able to compute torque? |
| annotation (Placement(transformation(extent={{-20,-10},{-40,10}}))); | ||
| Modelica.Electrical.Analog.Sources.ConstantCurrent | ||
| constantCurrent(I=settings.Idc) | ||
| Analog.Sources.ConstantVoltage |
There was a problem hiding this comment.
| Analog.Sources.ConstantVoltage | |
| Modelica.Electrical.Analog.Sources.ConstantVoltage |
I know that both variants work, but I find it confusing that just a few declarations use a shorter name.
| Blocks.Sources.BooleanConstant booleanConstant(k=settings.layout == "Y2") | ||
| annotation (Placement(transformation(extent={{-90,0},{-70,20}}))); | ||
| Analog.Ideal.IdealOpeningSwitch switch annotation ( |
There was a problem hiding this comment.
| Blocks.Sources.BooleanConstant booleanConstant(k=settings.layout == "Y2") | |
| annotation (Placement(transformation(extent={{-90,0},{-70,20}}))); | |
| Analog.Ideal.IdealOpeningSwitch switch annotation ( | |
| Modelica.Blocks.Sources.BooleanConstant booleanConstant(k=settings.layout == "Y2") | |
| annotation (Placement(transformation(extent={{-90,0},{-70,20}}))); | |
| Modelica.Electrical.Analog.Ideal.IdealOpeningSwitch switch annotation ( |
Similarly.

enhances the mentioned example to avoid problems
changes the comparisonSignals (old ones are bad - see discussion in #4688)
@uschna pls. test
@GallLeo @MatthiasBSchaefer pls. prodice new reference result - thx!
@casella should we backport to 4.1.1? I suppose "no".