CMake: Set GCC version specific subfolder for MinGW#4671
Open
beutlich wants to merge 2 commits intomodelica:masterfrom
Open
CMake: Set GCC version specific subfolder for MinGW#4671beutlich wants to merge 2 commits intomodelica:masterfrom
beutlich wants to merge 2 commits intomodelica:masterfrom
Conversation
beutlich
added
L: Resources
maltelenz
reviewed
Jul 14, 2025
Contributor
maltelenz
left a comment
maltelenz
left a comment
There was a problem hiding this comment.
Could/should it use CMAKE_C_COMPILER_VERSION?
The general idea seems fine, but System Modeler doesn't have MinGW support, so I cannot do any real testing.
beutlich
force-pushed
the
set-gcc-specific-subfolder-for-mingw
branch
from
3eb5093 to
64c6872
Compare
beutlich
force-pushed
the
set-gcc-specific-subfolder-for-mingw
branch
from
64c6872 to
a8e7915
Compare
beutlich
force-pushed
the
set-gcc-specific-subfolder-for-mingw
branch
from
a8e7915 to
6d5ca5e
Compare
HansOlsson
approved these changes
Jan 13, 2026
Contributor
HansOlsson
left a comment
HansOlsson
left a comment
There was a problem hiding this comment.
Seems ok according to my coworkers who work more with gcc.
beutlich
force-pushed
the
set-gcc-specific-subfolder-for-mingw
branch
from
6d5ca5e to
92accf7
Compare
Member
Author
Contributor
@beutlich the end result seems fine, but why are you doing it yourself? Does the CMAKE variable not do what you want? Either way, I don't have strong opinions, so if you want to go ahead with this approach, let me know and I can provide the needed second approving review. |
beutlich
force-pushed
the
set-gcc-specific-subfolder-for-mingw
branch
from
92accf7 to
318a355
Compare
beutlich
requested review from
HansOlsson,
adrpo and
maltelenz
and removed request for
adrpo
maltelenz
approved these changes
Feb 9, 2026
beutlich
force-pushed
the
set-gcc-specific-subfolder-for-mingw
branch
from
318a355 to
1b971f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC x.y.z will create a subfolder gccxyz.