Fix URI template matching for multi-variable simple expressions#2218
Open
koriyoshi2041 wants to merge 1 commit into
Open
Fix URI template matching for multi-variable simple expressions#2218koriyoshi2041 wants to merge 1 commit into
koriyoshi2041 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 4c5f78f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
koriyoshi2041
force-pushed
the
fix-uri-template-multi-variable-match
branch
from
f4c33df to
4c5f78f
Compare
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
UriTemplate.match()for simple expressions that contain multiple variables, such as/users/{userId,format}.Previously the matcher generated one capture group for the whole expression and used a pattern that rejected commas, so
/users/42,jsonreturnednull. This now generates one capture group per variable with literal comma separators.Fixes #2166.
Testing
pnpm --filter @modelcontextprotocol/core test -- packages/core/test/shared/uriTemplate.test.tspnpm --filter @modelcontextprotocol/core lint