fix: support icons in registerTool config and tools/list response#1879
Open
Yanhu007 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: support icons in registerTool config and tools/list response#1879Yanhu007 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Yanhu007 wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
The MCP spec's ToolSchema includes icons (via IconsSchema), but McpServer.registerTool() did not accept icons in its config parameter, and the tools/list handler did not include icons in the tool definition. - Add icons to registerTool config type - Pass icons through _createRegisteredTool - Include icons in the tools/list response toolDefinition - Add icons to RegisteredTool type Fixes modelcontextprotocol#1864
🦋 Changeset detectedLatest commit: 8c763a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1864
The MCP spec's
ToolSchemaincludesicons(viaIconsSchema), butMcpServer.registerTool()has two gaps:configparameter type does not accepticonstools/listhandler does not includeiconsin the tool definitionChanges
icons?: Tool['icons']toregisterToolconfig typeiconsparameter to_createRegisteredTooliconsin thetoolDefinitionbuilt by thetools/listhandlericonsto theRegisteredTooltypeUsage