fix(memory): include type field in output schemas to fix validation error#4090
Open
aayushbaluni wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(memory): include type field in output schemas to fix validation error#4090aayushbaluni wants to merge 1 commit intomodelcontextprotocol:mainfrom
aayushbaluni wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…rror The memory server stores entities with a 'type' field in JSONL, but the tool output schemas did not include this property. When structured output validation is enabled, this causes MCP error -32602 for read_graph, search_nodes, and open_nodes tools. Fixes modelcontextprotocol#3074
aayushbaluni
force-pushed
the
fix/3074-memory-schema-validation
branch
from
42e3f80 to
d8d57b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3074
When structured output validation is enabled, the memory server's
read_graph,search_nodes, andopen_nodestools fail with MCP error -32602 because stored entities contain atypefield not declared in the output schema.Root Cause
Entities in the JSONL knowledge graph include a
typeproperty (discriminator for entity vs relation lines), but the tool output schemas used strict validation that rejected unknown properties.Fix
Declared optional
typeliterals on entity and relation Zod schemas and attach the discriminators when loading from JSONL so structured responses match both the file format and the output schema.Testing
npm testinsrc/memory)