fix(memory): use plain JSON Schema for outputSchema instead of Zod objects#3627
Open
ctonneslan wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(memory): use plain JSON Schema for outputSchema instead of Zod objects#3627ctonneslan wants to merge 1 commit intomodelcontextprotocol:mainfrom
ctonneslan wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
The memory server passed plain objects with Zod values as outputSchema
properties (e.g. { entities: z.array(...) }), but the SDK expects
outputSchema to be a full Zod schema (z.object({ ... })). This causes
type errors and serialization failures.
Wrapped all 9 outputSchema definitions in z.object() so the SDK can
properly convert them to JSON Schema via schemaToJson().
Fixes modelcontextprotocol#3622
ctonneslan
force-pushed
the
fix/memory-output-schema-json
branch
from
e8ca89d to
335c569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The memory server passes plain objects with Zod values as
outputSchema:The SDK's
McpServer.tool()expectsoutputSchemato be a full Zod schema (z.object()), not a plain object containing Zod schemas. This causes TypeScript type errors (AnySchemamismatch) and serialization failures when the SDK tries to convert viaschemaToJson().Fix
Wrapped all 9
outputSchemadefinitions inz.object():The SDK's
schemaToJson()then correctly converts the Zod schema to JSON Schema for thetools/listresponse.Fixes #3622