fix(schema): upgrade server.json dialect to JSON Schema 2020-12#1446
Open
piyushbag wants to merge 1 commit into
Open
fix(schema): upgrade server.json dialect to JSON Schema 2020-12#1446piyushbag wants to merge 1 commit into
piyushbag wants to merge 1 commit into
Conversation
Match the OpenAPI jsonSchemaDialect and the official MCP server.json schema by emitting https://json-schema.org/draft/2020-12/schema from the extractor and regenerating the draft artifact. Fixes modelcontextprotocol#842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The generated
server.schema.jsonstill advertised JSON Schema draft-07 while OpenAPI already setsjsonSchemaDialectto 2020-12. This updates the extractor and regenerates the draft artifact to match.Approach
https://json-schema.org/draft/2020-12/schemafromtools/extract-server-schemadocs/reference/server-json/draft/server.schema.jsonTest plan
make generate-schemamake check-schemaFixes #842