Clarify docstring for Context implicit injection in Resource functions#792
Closed
sam-tombury wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
Clarify docstring for Context implicit injection in Resource functions#792sam-tombury wants to merge 1 commit intomodelcontextprotocol:mainfrom
sam-tombury wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Resource functions do not (currently) support context injection
Contributor
|
Thank you for flagging, there is an ongoing PR to add support, we can move the conversation there |
Contributor
Author
|
Awesome, thanks for pointing that out. I'll add a comment there about the interaction with concrete/direct resources and resource templates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource functions do not (currently) support context injection, but support is implied by the current
Contextdocstring. This change updates the docstring to accurately reflect the current implementation.Motivation and Context
Lack of clarity in documentation. Developers may try to implicitly inject
contextinto@resource-decorated functions following the current documentation and encounter surprising errors.How Has This Been Tested?
Documentation only
Breaking Changes
None
Types of changes
Checklist
Additional context
Context injection support for
resourcefunctions (as is the case fortools) would be very nice to have, but there seems to be some complexity in how that interacts with the concept of concrete/direct resources vs resource templates. In particular, a resource function might accept only aContextparam, for example if it lists all objects that a (contextual) user can access. Reading through the code, it appears that concrete resources are already lazy - so we could considerContext-only resources as concrete/direct and thread through thecontextin the read method. I'm happy to add a follow-up issue and work towards implementing that if there's interest.