Preserve non-ASCII characters in JSON output for better multilingual support#580
Closed
VvvvvGH wants to merge 2 commits intomodelcontextprotocol:mainfrom
Closed
Preserve non-ASCII characters in JSON output for better multilingual support#580VvvvvGH wants to merge 2 commits intomodelcontextprotocol:mainfrom
VvvvvGH wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
Add ensure_ascii=False parameter to json.dumps() when converting results to JSON strings in _convert_to_content function. This prevents Unicode characters (like Chinese) from being escaped as \uXXXX sequences, making the output more readable and user-friendly for multilingual content.
Contributor
|
Thank you for contributing to MCP Python SDK! Closing this PR for the same reason as #495, the issue was addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add ensure_ascii=False parameter to json.dumps() when converting results to JSON strings in _convert_to_content function. This prevents Unicode characters (like Chinese) from being escaped as \uXXXX sequences, making the output
more readable and user-friendly for multilingual content.
Comprehension Barriers for LLMs: AI models frequently struggle to properly parse and understand Unicode escape sequences. For example, when Chinese text "你好" is encoded as "\u4f60\u597d", large language models could mistakenly understand them.
How Has This Been Tested?
I have tested unicode characters and is working fine
Breaking Changes
No
Types of changes
Checklist
Additional context